iot: add mqtt gateway samples to GA #1169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
gguuss
approved these changes
Feb 19, 2019
Contributor
gguuss
left a comment
gguuss
left a comment
There was a problem hiding this comment.
LGTM, a few nits on examples variables in comments that you can ignore and address later or get in this PR.
| description: 'Public key format for devices.', | ||
| requiresArg: true, | ||
| choices: ['RS256_PEM', 'RS256_X509_PEM', 'ES256_PEM', 'ES256_X509_PEM'], | ||
| choices: ['RSA_PEM', 'RSA_X509_PEM', 'ES256_PEM', 'ES256_X509_PEM'], |
Contributor
There was a problem hiding this comment.
Nice. We should probably add these options to the other samples.
hongalex
added
the
kokoro:force-run
kokoro-team
removed
kokoro:force-run
This was referenced Jan 17, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloudiot_mqtt_example_nodejs.jssample to support different commands