Skip to content

Conversation

@hongalex
Copy link
Contributor

@hongalex hongalex commented Jan 4, 2019

new version of google.auth.getClient reads from environment variables so specifying a file isn't necessary anymore. However, for backwards compatibility, we'll keep the option to pass in the JSON file but make it optional

ref: internal bug b/120968399

@hongalex hongalex requested a review from gguuss January 4, 2019 06:35
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 4, 2019
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants