-
Notifications
You must be signed in to change notification settings - Fork 115
Update Danielle Adam's key as well as keyservers #225
Conversation
Deprecate her old key as DanielleAdamOld Updated the keyserver from "pool.sks-keyservers.net" -> "hkp://pgp.mit.edu:11371" as the old sks-keyserver is deprecated: https://unix.stackexchange.com/questions/656205/sks-keyservers-gone-what-to-use-instead Updated KEYS file (GoogleCloudPlatform#214)
|
||
for key in ${keylist} ; do | ||
gpg2 --keyserver pool.sks-keyservers.net --recv-keys ${key} | ||
gpg2 --keyserver hkp://pgp.mit.edu:11371 --recv-keys ${key} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you help me understand this change?
Seems like pool.sks-keyservers.net is deprecated. How reliable and stable is hkp://pgp.mit.edu:11371?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About pgp.mit.edu: https://pgp.mit.edu/about.html
About hkp: https://datatracker.ietf.org/doc/html/draft-shaw-openpgp-hkp-00
11371 is HKP default port
The future of nodejs release key next year is likely to use: https://github.com/nodejs/release-keys
For the upcoming 1-2 year, I think the mit host should be robust enough - it's unlikely they would need to shutdown their keyserver due to DMCA (like sks) given their nature as an education institution.
Good change +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this 👍🏼
@danielleadams can this one be merged please? |
FYI, I'm requesting permissions to merge this change. |
Deprecate Danielle's old key as DanielleAdamOld
Updated the keyserver from "pool.sks-keyservers.net" -> "hkp://pgp.mit.edu:11371" as the old sks-keyserver is deprecated: https://unix.stackexchange.com/questions/656205/sks-keyservers-gone-what-to-use-instead
Updated KEYS file (#214)