Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing typo to properly expand variable with multiple values #306

Closed
wants to merge 1 commit into from
Closed

Conversation

lutierigb
Copy link

in case there are two default routes the quotation marks will concatenate the interface names. without the quotes, each interface will be treated as a separate value in the for loop. see http://b/336186274#comment25

in case there are two default routes the quotation marks will concatenate the interface names. without the quotes, each interface will be treated as a separate value in the for loop. see http://b/336186274#comment25
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lutierigb
Once this PR has been reviewed and has the lgtm label, please assign anfernee for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jingyuanliang
Copy link
Member

Can we add a comment saying $default_nic may be multi-line specifying multiple interfaces? In case we forget this and add the quotes back later.

@jingyuanliang
Copy link
Member

#308 for a better version.

@lutierigb
Copy link
Author

closing in favor of #308

@lutierigb lutierigb closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants