Skip to content

Conversation

@algchoo
Copy link
Contributor

@algchoo algchoo commented Jul 13, 2023

Changes

Details
I'm not certain why the minimum version was 1.3.0 and because the metrics are exposed by default, my thought was to change the minimum version to the version of Velero that this plugin deploys. I used the latest version of the plugin, which claims support for Velero 1.11.0, which may be true, but I just checked and what's deployed is 1.10.1

Init Containers:
  velero-velero-plugin-for-gcp:
    Container ID:   containerd://6910f038efb86f20bdcb45bef497a3d79e8ff7a3c4fcd220dec689f13f6e64b4
    Image:          velero/velero-plugin-for-gcp:v1.7.0
    Image ID:       docker.io/velero/velero-plugin-for-gcp@sha256:1ed38c11563fa40d428b92a104913dccd704e616c95c66360a2136fd769ce600
    Port:           <none>
    Host Port:      <none>
    State:          Terminated
      Reason:       Completed
      Exit Code:    0
      Started:      Thu, 13 Jul 2023 10:22:08 -0400
      Finished:     Thu, 13 Jul 2023 10:22:08 -0400
    Ready:          True
    Restart Count:  0
    Environment:    <none>
    Mounts:
      /target from plugins (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-mvm4j (ro)
Containers:
  velero:
    Container ID:  containerd://dc2db8ef729c2bf7b4dce847c3a3f91ef838268ceee1b994b946c00a1b6d630f
    Image:         velero/velero:v1.10.1
    Image ID:      docker.io/velero/velero@sha256:b45e13f7e18e630a3061073242a8dcb1e4b70965a287633bc21f691c1e249c5a
    Port:          8085/TCP
    Host Port:     0/TCP
    Command:

@github-actions github-actions bot requested a review from yqlu July 13, 2023 20:33
@yqlu
Copy link
Collaborator

yqlu commented Jul 14, 2023

Thanks for checking this!

I just looked at the deployment in my toy cluster (deployed 6 months ago, when testing the original version of the checking), and not touched since:

Init Containers:
  velero-velero-plugin-for-gcp:
    Container ID:   containerd://51997ef267fd6e4feb45fb303b51b60ea2e63a7b89dd6f83b10527c90d98d6a3
    Image:          velero/velero-plugin-for-gcp:v1.6.0
    Image ID:       docker.io/velero/velero-plugin-for-gcp@sha256:3dbcf864421c4f36d9e620a3bdbc6222c8766fa25626d3209eaee0c285e53d57
    Port:           <none>
    Host Port:      <none>
    State:          Terminated
      Reason:       Completed
      Exit Code:    0
      Started:      Thu, 06 Jul 2023 00:01:45 +0000
      Finished:     Thu, 06 Jul 2023 00:01:45 +0000
    Ready:          True
    Restart Count:  0
    Environment:    <none>
    Mounts:
      /target from plugins (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-4645m (ro)
Containers:
  velero:
    Container ID:  containerd://8012360b4743262786507e2e2d86638beaa1a310bfb5238dbd8988dfcd9fba73
    Image:         velero/velero:v1.9.5
    Image ID:      docker.io/velero/velero@sha256:e69a8b1a0787f3c5e81301d6315b094a4dc60a378257762ba1c867abd083b31b
    Port:          8085/TCP
    Host Port:     0/TCP
    Command:
      /velero
    Args:
      server
      --features=
    State:          Running
      Started:      Thu, 06 Jul 2023 00:01:53 +0000
    Ready:          True
    Restart Count:  0
    Limits:
      cpu:     1
      memory:  512Mi
    Requests:
      cpu:     500m
      memory:  128Mi

Not super critical, but is it worth scanning the velero changelog to see if we can list an earlier supported version (e.g. 1.7.x ? , which is the earliest one that the older versions of the GCP plugin pull in?).

@algchoo
Copy link
Contributor Author

algchoo commented Jul 14, 2023

Thanks for checking this!

I just looked at the deployment in my toy cluster (deployed 6 months ago, when testing the original version of the checking), and not touched since:

Init Containers:
  velero-velero-plugin-for-gcp:
    Container ID:   containerd://51997ef267fd6e4feb45fb303b51b60ea2e63a7b89dd6f83b10527c90d98d6a3
    Image:          velero/velero-plugin-for-gcp:v1.6.0
    Image ID:       docker.io/velero/velero-plugin-for-gcp@sha256:3dbcf864421c4f36d9e620a3bdbc6222c8766fa25626d3209eaee0c285e53d57
    Port:           <none>
    Host Port:      <none>
    State:          Terminated
      Reason:       Completed
      Exit Code:    0
      Started:      Thu, 06 Jul 2023 00:01:45 +0000
      Finished:     Thu, 06 Jul 2023 00:01:45 +0000
    Ready:          True
    Restart Count:  0
    Environment:    <none>
    Mounts:
      /target from plugins (rw)
      /var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-4645m (ro)
Containers:
  velero:
    Container ID:  containerd://8012360b4743262786507e2e2d86638beaa1a310bfb5238dbd8988dfcd9fba73
    Image:         velero/velero:v1.9.5
    Image ID:      docker.io/velero/velero@sha256:e69a8b1a0787f3c5e81301d6315b094a4dc60a378257762ba1c867abd083b31b
    Port:          8085/TCP
    Host Port:     0/TCP
    Command:
      /velero
    Args:
      server
      --features=
    State:          Running
      Started:      Thu, 06 Jul 2023 00:01:53 +0000
    Ready:          True
    Restart Count:  0
    Limits:
      cpu:     1
      memory:  512Mi
    Requests:
      cpu:     500m
      memory:  128Mi

Not super critical, but is it worth scanning the velero changelog to see if we can list an earlier supported version (e.g. 1.7.x ? , which is the earliest one that the older versions of the GCP plugin pull in?).

Just tried this out, installed velero version 1.7.1 and used the appropriate plugin, the dashboard/metrics appear as expected.

@yqlu yqlu merged commit 33e58bf into GoogleCloudPlatform:master Jul 14, 2023
algchoo added a commit to observIQ/monitoring-dashboard-samples that referenced this pull request Aug 15, 2023
* updated min exporter version to be the latest version of Velero supported by the GCP plugin for Velero

* the plugin support matrix doesn't match what is deployed, changed the minimum supported version

* updated the minimum exporter version to be 1.7.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants