Skip to content

Updated Consul Prometheus documentation#584

Closed
algchoo wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
observIQ:docs/consul-image-name
Closed

Updated Consul Prometheus documentation#584
algchoo wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
observIQ:docs/consul-image-name

Conversation

@algchoo
Copy link
Contributor

@algchoo algchoo commented Jul 12, 2023

Changes

Details
Updated the minimum version for the exporter in the documentation and metadata. Due to the image name changing, that is updated (just noticed that I missed this part, sorry for the confusing commits) in the documentation, as well.

@github-actions github-actions bot requested a review from pintofloyed July 12, 2023 15:45
@yqlu
Copy link
Collaborator

yqlu commented Jul 14, 2023

Just double-checking, why is this version bump necessary? Back when we published this, we did verify that consul 1.13.x does work and you can get the necessary metrics scraped by GMP?

Should we only bump minimum supported exporter versions when there is actually a breaking change in the config (like in #580) or if the new version emits some new metrics that we are showcasing in the dashboard?

@algchoo
Copy link
Contributor Author

algchoo commented Jul 17, 2023

Just double-checking, why is this version bump necessary? Back when we published this, we did verify that consul 1.13.x does work and you can get the necessary metrics scraped by GMP?

Should we only bump minimum supported exporter versions when there is actually a breaking change in the config (like in #580) or if the new version emits some new metrics that we are showcasing in the dashboard?

I agree with you on this, but wasn't sure initially. These changes do not have an effect on the dashboard/alerts, no other breaking change that I'm aware of exists. I'll update this.

@algchoo
Copy link
Contributor Author

algchoo commented Jul 17, 2023

Just double-checking, why is this version bump necessary? Back when we published this, we did verify that consul 1.13.x does work and you can get the necessary metrics scraped by GMP?
Should we only bump minimum supported exporter versions when there is actually a breaking change in the config (like in #580) or if the new version emits some new metrics that we are showcasing in the dashboard?

I agree with you on this, but wasn't sure initially. These changes do not have an effect on the dashboard/alerts, no other breaking change that I'm aware of exists. I'll update this.

If we are keeping the minimum version as is, I don't see a reason to change the documentation either, even with the newer image having a slightly different name, I'll close this PR.

@algchoo algchoo closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants