Add google_dns_managed_zones data source and acceptance test
#9742
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 323 insertions(+), 1 deletion(-)) |
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocClusterIamPolicy |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
👆 I removed the skip as I believe the issue in hashicorp/terraform-provider-google#14158 isn't due to the plugin framework necessarily. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 321 insertions(+), 1 deletion(-)) |
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceDnsManagedZones_basic |
|
Rerun these tests in REPLAYING mode to catch issues
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.
|
Dammit, seems like there is a problem related to the migrated data sources 🤦 |
|
Hi @roaks3 , I'm working on a customer request to implement this plural data source and decided to implement it using the plugin-framework to match other What are you opinions on leaving this as using the PF versus implementing it using the SDK? I'm torn between wanting to keep the |
|
I brought up this in the HashiCorp/Google sync yesterday, and @rileykarson said that implementing this data source using the plugin framework was ok given that it's a customer request and that the issue with VCR tests & the plugin framework is investigated soon. I'll advocate for that work to be included in my Q1 plans (starting in Feb). Because of that I'll skip this PR's new test in VCR. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 323 insertions(+), 1 deletion(-)) |
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocJobIamPolicy |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Sorry for the delay on this. I think that makes sense to stick with PF to get this implemented more quickly, and so +1 on skipping the tests here. Will give this a review within the next hour or so. |
mmv1/third_party/terraform/services/dns/data_source_dns_managed_zones.go
Show resolved
Hide resolved
|
Thanks for spotting that problem with the schema when I copied it from singular => plural data source! In future I hope to identify how we can write data source in the plugin-framework and re-use schemas with minor edits, similar to what we do for SDK resources and data sources. I've pushed a change to the test to make it interrogate the managed zone elements more closely, to ensure the fields for those elements are being populated as expected. The tests passes locally. Previously the less-strict version of the test passed on the PR in recording mode (the pass seen here) but failed in replay mode due to the plugin framework related problem. |
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataprocClusterIamPolicy |
|
Rerun these tests in REPLAYING mode to catch issues
|
…eCloudPlatform#9742) * Add `google_dns_managed_zones` data source and acceptance test * Stop skipping `TestAccDataSourceDnsManagedZones_basic` in VCR * Skip acceptance test affected by PF/VCR incompatibility * Edit schema to make sense for a plural data source * Update test to explicitly check for elements' fields being set
…eCloudPlatform#9742) * Add `google_dns_managed_zones` data source and acceptance test * Stop skipping `TestAccDataSourceDnsManagedZones_basic` in VCR * Skip acceptance test affected by PF/VCR incompatibility * Edit schema to make sense for a plural data source * Update test to explicitly check for elements' fields being set
…eCloudPlatform#9742) * Add `google_dns_managed_zones` data source and acceptance test * Stop skipping `TestAccDataSourceDnsManagedZones_basic` in VCR * Skip acceptance test affected by PF/VCR incompatibility * Edit schema to make sense for a plural data source * Update test to explicitly check for elements' fields being set
…eCloudPlatform#9742) * Add `google_dns_managed_zones` data source and acceptance test * Stop skipping `TestAccDataSourceDnsManagedZones_basic` in VCR * Skip acceptance test affected by PF/VCR incompatibility * Edit schema to make sense for a plural data source * Update test to explicitly check for elements' fields being set
Closes hashicorp/terraform-provider-google#15737
Release Note Template for Downstream PRs (will be copied)