Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filestore: zonal tier support #8987

Merged

Conversation

bsteinberg
Copy link
Member

@bsteinberg bsteinberg commented Sep 18, 2023

Zonal tier support for Filestore.

Release Note Template for Downstream PRs (will be copied)

filestore: added support for the `"ZONAL"` value to `tier` in `google_filestore_instance`

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3065
Passed tests 2766
Skipped tests: 299
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

@rileykarson rileykarson merged commit 0286722 into GoogleCloudPlatform:main Sep 18, 2023
17 of 18 checks passed
@rileykarson
Copy link
Member

This already worked for new resources since we don't validate the value anymore, but adding to release notes anyways in case users were unaware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants