-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Network and Subnet resources for edgenetwork #8905
Conversation
Hello! I am a robot. It looks like you are a: Community Contributor @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 16 files changed, 1910 insertions(+), 2 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_edgenetwork_network" "primary" {
labels = # value needed
}
Resource: resource "google_edgenetwork_subnet" "primary" {
labels = # value needed
}
|
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccEdgenetworkSubnet_edgenetworkSubnetWithVlanIdExample|TestAccEdgenetworkSubnet_edgenetworkSubnetExample|TestAccEdgenetworkNetwork_edgenetworkNetworkExample |
|
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 16 files changed, 1910 insertions(+), 2 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_edgenetwork_network" "primary" {
labels = # value needed
}
Resource: resource "google_edgenetwork_subnet" "primary" {
labels = # value needed
}
|
Can you please add the labels field to the tests? Please check the missing test report for details. |
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccEdgenetworkSubnet_edgenetworkSubnetWithVlanIdExample|TestAccEdgenetworkNetwork_edgenetworkNetworkExample|TestAccEdgenetworkSubnet_edgenetworkSubnetExample|TestAccHealthcareDatasetIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
Can you also fix the failed tests? Thanks. |
These tests are failing because they don't have a valid GDCE zone to operate on. Unfortunately the edgenetwork API does not support the creation of a zone without an actual hardware deployment. Can we skip these tests? |
Is there a doc how to create a zone with an actual hardware deployment? Thanks. |
Internally in GDCE we have several zones created for testing/development purposes, which I can use to run these acceptance tests. However I'm not sure it's a good idea to expose the details for them in a public GitHub repo. Alternatively, a GDCE zone can be purchased and provisioned via these steps. Currently it is not possible to run any kind of E2E test for the edgenetwork API without owning some GDCE hardware, either provided by Google internally or purchased as a customer. To me, neither of these options seem to make sense for an open-source project. I can confirm these tests are passing when I run them on a test zone. Would it be okay to disable these tests in the CI, and leave them as manual-run only? |
…e from vlan_id field in Subnet
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 16 files changed, 1928 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample|TestAccEdgenetworkNetwork_edgenetworkNetworkExample|TestAccEdgenetworkSubnet_edgenetworkSubnetWithVlanIdExample|TestAccEdgenetworkSubnet_edgenetworkSubnetExample|TestAccMonitoringMonitoredProject_monitoringMonitoredProjectLongFormExample|TestAccMonitoringMonitoredProject_projectNumLongForm|TestAccMonitoringMonitoredProject_projectNumShortForm|TestAccMonitoringMonitoredProject_monitoringMonitoredProjectBasicExample|TestAccSpannerDatabaseIamPolicy |
Rerun these tests in REPLAYING mode to catch issues
|
You can remove these tests by adding
There is no way to leave them as manual-run only. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 14 files changed, 1639 insertions(+), 2 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_edgenetwork_network" "primary" {
description = # value needed
labels = # value needed
location = # value needed
mtu = # value needed
network_id = # value needed
zone = # value needed
}
Resource: resource "google_edgenetwork_subnet" "primary" {
description = # value needed
ipv4_cidr = # value needed
ipv6_cidr = # value needed
labels = # value needed
location = # value needed
network = # value needed
subnet_id = # value needed
vlan_id = # value needed
zone = # value needed
}
|
Tests analyticsTotal tests:
|
LGTM. Thanks. |
…#8905) * Add Network and Subnet resources for edgenetwork * Fix lint * Added labels field to acceptance tests; Removed send_empty_value:false from vlan_id field in Subnet * Skip edgenetwork acceptance tests
This PR adds two new resources,
Network
andSubnet
, under a new productedgenetwork
.Fixes this issue: hashicorp/terraform-provider-google#15664
Release Note Template for Downstream PRs (will be copied)