Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows storage bucket autoclass to be modified (where available) #8891

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

thomasmaclean
Copy link
Contributor

@thomasmaclean thomasmaclean commented Sep 7, 2023

Changes autoclass to not be an immutable field on storage buckets. Tests are not enabled for this feature as this is not available everywhere.

Release Note Template for Downstream PRs (will be copied)

storage: supported in-place update for `autoclass` field in `google_storage_bucket` resource

@modular-magician
Copy link
Collaborator

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3018
Passed tests 2719
Skipped tests: 297
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFolderIamPolicy_basic|TestAccStorageBucket_basicWithAutoclass

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccFolderIamPolicy_basic[Debug log]
TestAccStorageBucket_basicWithAutoclass[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on it.

@zli82016
Copy link
Member

zli82016 commented Sep 8, 2023

It looks like TestAccStorageBucket_basicWithAutoclass covers the update of this field and passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants