-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows storage bucket autoclass to be modified (where available) #8891
Conversation
42cc51d
to
cb543bf
Compare
Hello! I am a robot. It looks like you are a: @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccFolderIamPolicy_basic|TestAccStorageBucket_basicWithAutoclass |
Rerun these tests in REPLAYING mode to catch issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for working on it.
It looks like TestAccStorageBucket_basicWithAutoclass covers the update of this field and passed. |
Changes autoclass to not be an immutable field on storage buckets. Tests are not enabled for this feature as this is not available everywhere.
Release Note Template for Downstream PRs (will be copied)