-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Clarify usage of schema
in Table
#8661
Fix: Clarify usage of schema
in Table
#8661
Conversation
Hello! I am a robot. It looks like you are a: @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 18 insertions(+), 2 deletions(-)) |
mmv1/third_party/terraform/website/docs/r/bigquery_table.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/bigquery_table.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/bigquery_table.html.markdown
Outdated
Show resolved
Hide resolved
…markdown Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
…markdown Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
…markdown Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 18 insertions(+), 2 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also adjust the surrounding lines - unfortunately GitHub does not support multi-line suggestions.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 17 insertions(+), 7 deletions(-)) |
* Fix: Clarify usage of `schema` in Table * Update mmv1/third_party/terraform/website/docs/r/bigquery_table.html.markdown Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Update mmv1/third_party/terraform/website/docs/r/bigquery_table.html.markdown Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Update mmv1/third_party/terraform/website/docs/r/bigquery_table.html.markdown Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * fix: delete extra info * add: anchor for `schema` * fix: follow existing anchor convention --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
* Fix: Clarify usage of `schema` in Table * Update mmv1/third_party/terraform/website/docs/r/bigquery_table.html.markdown Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Update mmv1/third_party/terraform/website/docs/r/bigquery_table.html.markdown Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * Update mmv1/third_party/terraform/website/docs/r/bigquery_table.html.markdown Co-authored-by: Stephen Lewis (Burrows) <[email protected]> * fix: delete extra info * add: anchor for `schema` * fix: follow existing anchor convention --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Our users highlighted unclear documentation, which I have clarified in this PR.
Fixes: hashicorp/terraform-provider-google#15377
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)