-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cloud Run v1 Multi-Container Example with New Fields #7971
Conversation
Adds the template.spec.containers.name field for specifying container names in Cloud Run v1 Services.
Updates the description of the Cloud Run v1 Service field template.spec.containers to reflect that the field is repeated and to remove other obsolete information.
Adds the beta template.spec.volumes.empty_dir field for configuring ephemeral volumes in Cloud Run v1 Services.
Adds an example google_cloud_run_service resource with multiple containers and a shared empty dir volume. Container dependencies are specified as a json encoded annotation.
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @hao-nan-li, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 114 insertions(+), 11 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSqlUser_postgres|TestAccSqlUser_postgresIAM|TestAccSqlUser_postgresAbandon|TestAccComputeFirewallPolicyRule_multipleRules|TestAccCloudRunService_cloudRunServiceMulticontainerExample|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbCluster_missingLocation|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…Platform#7971) * cloudrun: Add container name field for Services Adds the template.spec.containers.name field for specifying container names in Cloud Run v1 Services. * cloudrun: Update the description of the Service containers field Updates the description of the Cloud Run v1 Service field template.spec.containers to reflect that the field is repeated and to remove other obsolete information. * cloudrun: Add empty dir volume type for Services Adds the beta template.spec.volumes.empty_dir field for configuring ephemeral volumes in Cloud Run v1 Services. * cloudrun: Add multi-container Service example Adds an example google_cloud_run_service resource with multiple containers and a shared empty dir volume. Container dependencies are specified as a json encoded annotation.
…Platform#7971) * cloudrun: Add container name field for Services Adds the template.spec.containers.name field for specifying container names in Cloud Run v1 Services. * cloudrun: Update the description of the Service containers field Updates the description of the Cloud Run v1 Service field template.spec.containers to reflect that the field is repeated and to remove other obsolete information. * cloudrun: Add empty dir volume type for Services Adds the beta template.spec.volumes.empty_dir field for configuring ephemeral volumes in Cloud Run v1 Services. * cloudrun: Add multi-container Service example Adds an example google_cloud_run_service resource with multiple containers and a shared empty dir volume. Container dependencies are specified as a json encoded annotation.
…Platform#7971) * cloudrun: Add container name field for Services Adds the template.spec.containers.name field for specifying container names in Cloud Run v1 Services. * cloudrun: Update the description of the Service containers field Updates the description of the Cloud Run v1 Service field template.spec.containers to reflect that the field is repeated and to remove other obsolete information. * cloudrun: Add empty dir volume type for Services Adds the beta template.spec.volumes.empty_dir field for configuring ephemeral volumes in Cloud Run v1 Services. * cloudrun: Add multi-container Service example Adds an example google_cloud_run_service resource with multiple containers and a shared empty dir volume. Container dependencies are specified as a json encoded annotation.
Adds support for the container name and empty dir volume fields in Cloud Run v1 Services and adds a multi-container example using these fields.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
in the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)