-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add datasources for all iam_resources #7936
add datasources for all iam_resources #7936
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 128 files changed, 1806 insertions(+), 127 deletions(-)) |
You may want to roll a replacement reviewer- I'm out tomorrow. Before closing out the issue, keep in mind that there are the handwritten ones as well! |
Tests analyticsTotal tests: Action takenFound 74 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated|TestAccBigqueryAnalyticsHubListingIamPolicyGenerated|TestAccBigQueryTableIamPolicyGenerated|TestAccBigqueryConnectionConnectionIamPolicyGenerated|TestAccBigqueryAnalyticsHubDataExchangeIamPolicyGenerated|TestAccArtifactRegistryRepositoryIamPolicyGenerated|TestAccApiGatewayGatewayIamPolicyGenerated|TestAccApiGatewayApiIamPolicyGenerated|TestAccApiGatewayApiConfigIamPolicyGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccIapAppEngineVersionIamPolicyGenerated|TestAccWorkstationsWorkstationConfigIamPolicyGenerated|TestAccServiceDirectoryNamespaceIamPolicyGenerated|TestAccSourceRepoRepositoryIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccServiceDirectoryServiceIamPolicyGenerated|TestAccSecretManagerSecretIamPolicyGenerated|TestAccRuntimeConfigConfigIamPolicyGenerated|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccIapWebBackendServiceIamPolicyGenerated|TestAccPrivatecaCaPoolIamPolicyGenerated|TestAccGKEHubMembershipIamPolicyGenerated|TestAccNotebooksInstanceIamPolicyGenerated|TestAccIapWebTypeAppEngineIamPolicyGenerated|TestAccNotebooksRuntimeIamPolicyGenerated|TestAccStorageBucketIamPolicyGenerated|TestAccIapWebTypeComputeIamPolicyGenerated|TestAccIapWebIamPolicyGenerated|TestAccWorkstationsWorkstationIamPolicyGenerated|TestAccHealthcareConsentStoreIamPolicyGenerated|TestAccVertexAIFeaturestoreIamPolicyGenerated|TestAccGKEBackupBackupPlanIamPolicyGenerated|TestAccDataprocMetastoreServiceIamPolicyGenerated|TestAccAlloydbBackup_missingLocation|TestAccIapTunnelInstanceIamPolicyGenerated|TestAccDNSManagedZoneIamPolicyGenerated|TestAccIapAppEngineServiceIamPolicyGenerated|TestAccPubsubTopicIamPolicyGenerated|TestAccVertexAIFeaturestoreEntitytypeIamPolicyGenerated|TestAccAlloydbCluster_missingLocation|TestAccDataFusionInstanceIamPolicyGenerated|TestAccDataCatalogPolicyTagIamPolicyGenerated|TestAccServiceManagementServiceConsumersIamPolicyGenerated|TestAccDataCatalogTagTemplateIamPolicyGenerated|TestAccDataCatalogTaxonomyIamPolicyGenerated|TestAccDataplexLakeIamPolicyGenerated|TestAccDataCatalogEntryGroupIamPolicyGenerated|TestAccComputeInstanceIamPolicyGenerated|TestAccDataprocAutoscalingPolicyIamPolicyGenerated|TestAccServiceManagementServiceIamPolicyGenerated|TestAccDataplexZoneIamPolicyGenerated|TestAccCloudIotDeviceRegistryIamPolicyGenerated|TestAccComputeRegionDiskIamPolicyGenerated|TestAccComputeSnapshotIamPolicyGenerated|TestAccDataplexAssetIamPolicyGenerated|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccCloudfunctions2functionIamPolicyGenerated|TestAccComputeBackendServiceIamPolicyGenerated|TestAccComputeBackendBucketIamPolicyGenerated|TestAccComputeDiskIamPolicyGenerated|TestAccCloudRunV2ServiceIamPolicyGenerated|TestAccBinaryAuthorizationAttestorIamPolicyGenerated|TestAccCloudFunctionsCloudFunctionIamPolicyGenerated|TestAccComputeMachineImageIamPolicyGenerated|TestAccCloudTasksQueueIamPolicyGenerated|TestAccIapTunnelIamPolicyGenerated|TestAccComputeSubnetworkIamPolicyGenerated|TestAccCloudRunV2JobIamPolicyGenerated|TestAccCloudRunServiceIamPolicyGenerated|TestAccComputeImageIamPolicyGenerated |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Re - handwritten IAM.. Should I consider those out of scope for this bug ? Or is adding those also a requirement? |
/gcbrun |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 128 files changed, 1806 insertions(+), 127 deletions(-)) |
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 128 files changed, 1806 insertions(+), 127 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbCluster_missingLocation|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic |
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbBackup_missingLocation|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 201 files changed, 5635 insertions(+), 127 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbCluster_missingLocation|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 239 files changed, 5726 insertions(+), 158 deletions(-)) |
Tests analyticsTotal tests: Errors occurred during REPLAYING mode. Please fix them to complete your PR |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 239 files changed, 5726 insertions(+), 158 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 26 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccHealthcareFhirStoreIamPolicy|TestAccProjectIamPolicy_invalidMembers|TestAccKmsCryptoKeyIamPolicy|TestAccHealthcareDicomStoreIamPolicy|TestAccHealthcareDatasetIamPolicy|TestAccProjectIamPolicy_basic|TestAccSqlUser_postgresAbandon|TestAccSqlUser_postgres|TestAccSqlUser_postgresIAM|TestAccHealthcareHl7V2StoreIamPolicy|TestAccDataprocClusterIamPolicy|TestAccServiceAccountIamPolicy|TestAccDataprocJobIamPolicy|TestAccFolderIamPolicy_basic|TestAccContainerCluster_withDatabaseEncryption|TestAccComputeFirewallPolicyRule_multipleRules|TestAccPubsubSubscriptionIamPolicy|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccBigqueryDatasetIamPolicy|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccSpannerInstanceIamPolicy|TestAccSpannerDatabaseIamPolicy|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 239 files changed, 5726 insertions(+), 158 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccFolderIamPolicy_basic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Only small comments
mmv1/third_party/terraform/tests/resource_google_billing_account_iam_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Shuya Ma <[email protected]>
Co-authored-by: Shuya Ma <[email protected]>
…nt_iam_test.go Co-authored-by: Shuya Ma <[email protected]>
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 239 files changed, 5726 insertions(+), 158 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccHealthcareHl7V2StoreIamPolicy|TestAccDataSourceAlloydbLocations_basic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbCluster_missingLocation|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 239 files changed, 5799 insertions(+), 158 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccProjectIamPolicy_invalidMembers|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbCluster_missingLocation|TestAccDataSourceAlloydbLocations_basic |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
…7936) Co-authored-by: Shuya Ma <[email protected]>
…7936) Co-authored-by: Shuya Ma <[email protected]>
…7936) Co-authored-by: Shuya Ma <[email protected]>
Helps with hashicorp/terraform-provider-google#14095
Release Note Template for Downstream PRs (will be copied)