add datasources for all iam_resources #7936

ScottSuarez · 2023-05-12T00:14:23Z

Helps with hashicorp/terraform-provider-google#14095

Release Note Template for Downstream PRs (will be copied)

`google_**_iam_policy`

modular-magician · 2023-05-12T00:32:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 128 files changed, 1806 insertions(+), 127 deletions(-))
Terraform Beta: Diff ( 142 files changed, 1974 insertions(+), 138 deletions(-))

rileykarson · 2023-05-12T00:39:41Z

You may want to roll a replacement reviewer- I'm out tomorrow. Before closing out the issue, keep in mind that there are the handwritten ones as well!

modular-magician · 2023-05-12T01:24:27Z

Tests analytics

Total tests: 2729
Passed tests 2377
Skipped tests: 278
Affected tests: 74

Action taken

Found 74 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated|TestAccBigqueryAnalyticsHubListingIamPolicyGenerated|TestAccBigQueryTableIamPolicyGenerated|TestAccBigqueryConnectionConnectionIamPolicyGenerated|TestAccBigqueryAnalyticsHubDataExchangeIamPolicyGenerated|TestAccArtifactRegistryRepositoryIamPolicyGenerated|TestAccApiGatewayGatewayIamPolicyGenerated|TestAccApiGatewayApiIamPolicyGenerated|TestAccApiGatewayApiConfigIamPolicyGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccIapAppEngineVersionIamPolicyGenerated|TestAccWorkstationsWorkstationConfigIamPolicyGenerated|TestAccServiceDirectoryNamespaceIamPolicyGenerated|TestAccSourceRepoRepositoryIamPolicyGenerated|TestAccPrivatecaCertificateTemplateIamPolicyGenerated|TestAccServiceDirectoryServiceIamPolicyGenerated|TestAccSecretManagerSecretIamPolicyGenerated|TestAccRuntimeConfigConfigIamPolicyGenerated|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccIapWebBackendServiceIamPolicyGenerated|TestAccPrivatecaCaPoolIamPolicyGenerated|TestAccGKEHubMembershipIamPolicyGenerated|TestAccNotebooksInstanceIamPolicyGenerated|TestAccIapWebTypeAppEngineIamPolicyGenerated|TestAccNotebooksRuntimeIamPolicyGenerated|TestAccStorageBucketIamPolicyGenerated|TestAccIapWebTypeComputeIamPolicyGenerated|TestAccIapWebIamPolicyGenerated|TestAccWorkstationsWorkstationIamPolicyGenerated|TestAccHealthcareConsentStoreIamPolicyGenerated|TestAccVertexAIFeaturestoreIamPolicyGenerated|TestAccGKEBackupBackupPlanIamPolicyGenerated|TestAccDataprocMetastoreServiceIamPolicyGenerated|TestAccAlloydbBackup_missingLocation|TestAccIapTunnelInstanceIamPolicyGenerated|TestAccDNSManagedZoneIamPolicyGenerated|TestAccIapAppEngineServiceIamPolicyGenerated|TestAccPubsubTopicIamPolicyGenerated|TestAccVertexAIFeaturestoreEntitytypeIamPolicyGenerated|TestAccAlloydbCluster_missingLocation|TestAccDataFusionInstanceIamPolicyGenerated|TestAccDataCatalogPolicyTagIamPolicyGenerated|TestAccServiceManagementServiceConsumersIamPolicyGenerated|TestAccDataCatalogTagTemplateIamPolicyGenerated|TestAccDataCatalogTaxonomyIamPolicyGenerated|TestAccDataplexLakeIamPolicyGenerated|TestAccDataCatalogEntryGroupIamPolicyGenerated|TestAccComputeInstanceIamPolicyGenerated|TestAccDataprocAutoscalingPolicyIamPolicyGenerated|TestAccServiceManagementServiceIamPolicyGenerated|TestAccDataplexZoneIamPolicyGenerated|TestAccCloudIotDeviceRegistryIamPolicyGenerated|TestAccComputeRegionDiskIamPolicyGenerated|TestAccComputeSnapshotIamPolicyGenerated|TestAccDataplexAssetIamPolicyGenerated|TestAccComputeRegionBackendServiceIamPolicyGenerated|TestAccCloudfunctions2functionIamPolicyGenerated|TestAccComputeBackendServiceIamPolicyGenerated|TestAccComputeBackendBucketIamPolicyGenerated|TestAccComputeDiskIamPolicyGenerated|TestAccCloudRunV2ServiceIamPolicyGenerated|TestAccBinaryAuthorizationAttestorIamPolicyGenerated|TestAccCloudFunctionsCloudFunctionIamPolicyGenerated|TestAccComputeMachineImageIamPolicyGenerated|TestAccCloudTasksQueueIamPolicyGenerated|TestAccIapTunnelIamPolicyGenerated|TestAccComputeSubnetworkIamPolicyGenerated|TestAccCloudRunV2JobIamPolicyGenerated|TestAccCloudRunServiceIamPolicyGenerated|TestAccComputeImageIamPolicyGenerated

Get to know how VCR tests work

modular-magician · 2023-05-12T02:11:04Z

Tests passed during RECORDING mode:
TestAccBigqueryDatapolicyDataPolicyIamPolicyGenerated[Debug log]
TestAccBigqueryAnalyticsHubListingIamPolicyGenerated[Debug log]
TestAccBigQueryTableIamPolicyGenerated[Debug log]
TestAccBigqueryConnectionConnectionIamPolicyGenerated[Debug log]
TestAccBigqueryAnalyticsHubDataExchangeIamPolicyGenerated[Debug log]
TestAccArtifactRegistryRepositoryIamPolicyGenerated[Debug log]
TestAccApiGatewayGatewayIamPolicyGenerated[Debug log]
TestAccApiGatewayApiIamPolicyGenerated[Debug log]
TestAccApiGatewayApiConfigIamPolicyGenerated[Debug log]
TestAccApigeeEnvironmentIamPolicyGenerated[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccIapAppEngineVersionIamPolicyGenerated[Debug log]
TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Debug log]
TestAccServiceDirectoryNamespaceIamPolicyGenerated[Debug log]
TestAccSourceRepoRepositoryIamPolicyGenerated[Debug log]
TestAccPrivatecaCertificateTemplateIamPolicyGenerated[Debug log]
TestAccServiceDirectoryServiceIamPolicyGenerated[Debug log]
TestAccSecretManagerSecretIamPolicyGenerated[Debug log]
TestAccRuntimeConfigConfigIamPolicyGenerated[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccIapWebBackendServiceIamPolicyGenerated[Debug log]
TestAccPrivatecaCaPoolIamPolicyGenerated[Debug log]
TestAccGKEHubMembershipIamPolicyGenerated[Debug log]
TestAccNotebooksInstanceIamPolicyGenerated[Debug log]
TestAccIapWebTypeAppEngineIamPolicyGenerated[Debug log]
TestAccNotebooksRuntimeIamPolicyGenerated[Debug log]
TestAccStorageBucketIamPolicyGenerated[Debug log]
TestAccIapWebTypeComputeIamPolicyGenerated[Debug log]
TestAccIapWebIamPolicyGenerated[Debug log]
TestAccWorkstationsWorkstationIamPolicyGenerated[Debug log]
TestAccHealthcareConsentStoreIamPolicyGenerated[Debug log]
TestAccVertexAIFeaturestoreIamPolicyGenerated[Debug log]
TestAccGKEBackupBackupPlanIamPolicyGenerated[Debug log]
TestAccDataprocMetastoreServiceIamPolicyGenerated[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccIapTunnelInstanceIamPolicyGenerated[Debug log]
TestAccDNSManagedZoneIamPolicyGenerated[Debug log]
TestAccIapAppEngineServiceIamPolicyGenerated[Debug log]
TestAccPubsubTopicIamPolicyGenerated[Debug log]
TestAccVertexAIFeaturestoreEntitytypeIamPolicyGenerated[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccDataFusionInstanceIamPolicyGenerated[Debug log]
TestAccDataCatalogPolicyTagIamPolicyGenerated[Debug log]
TestAccServiceManagementServiceConsumersIamPolicyGenerated[Debug log]
TestAccDataCatalogTagTemplateIamPolicyGenerated[Debug log]
TestAccDataCatalogTaxonomyIamPolicyGenerated[Debug log]
TestAccDataplexLakeIamPolicyGenerated[Debug log]
TestAccDataCatalogEntryGroupIamPolicyGenerated[Debug log]
TestAccComputeInstanceIamPolicyGenerated[Debug log]
TestAccDataprocAutoscalingPolicyIamPolicyGenerated[Debug log]
TestAccServiceManagementServiceIamPolicyGenerated[Debug log]
TestAccDataplexZoneIamPolicyGenerated[Debug log]
TestAccCloudIotDeviceRegistryIamPolicyGenerated[Debug log]
TestAccComputeRegionDiskIamPolicyGenerated[Debug log]
TestAccComputeSnapshotIamPolicyGenerated[Debug log]
TestAccDataplexAssetIamPolicyGenerated[Debug log]
TestAccComputeRegionBackendServiceIamPolicyGenerated[Debug log]
TestAccCloudfunctions2functionIamPolicyGenerated[Debug log]
TestAccComputeBackendServiceIamPolicyGenerated[Debug log]
TestAccComputeBackendBucketIamPolicyGenerated[Debug log]
TestAccComputeDiskIamPolicyGenerated[Debug log]
TestAccCloudRunV2ServiceIamPolicyGenerated[Debug log]
TestAccBinaryAuthorizationAttestorIamPolicyGenerated[Debug log]
TestAccCloudFunctionsCloudFunctionIamPolicyGenerated[Debug log]
TestAccComputeMachineImageIamPolicyGenerated[Debug log]
TestAccCloudTasksQueueIamPolicyGenerated[Debug log]
TestAccIapTunnelIamPolicyGenerated[Debug log]
TestAccComputeSubnetworkIamPolicyGenerated[Debug log]
TestAccCloudRunV2JobIamPolicyGenerated[Debug log]
TestAccCloudRunServiceIamPolicyGenerated[Debug log]
TestAccComputeImageIamPolicyGenerated[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

ScottSuarez · 2023-05-12T15:23:53Z

You may want to roll a replacement reviewer- I'm out tomorrow. Before closing out the issue, keep in mind that there are the handwritten ones as well!

Re - handwritten IAM.. Should I consider those out of scope for this bug ? Or is adding those also a requirement?

…odules into iam-datasources

ScottSuarez · 2023-05-15T22:50:47Z

/gcbrun

modular-magician · 2023-05-15T23:06:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 128 files changed, 1806 insertions(+), 127 deletions(-))
Terraform Beta: Diff ( 142 files changed, 1974 insertions(+), 138 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-05-15T23:09:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 128 files changed, 1806 insertions(+), 127 deletions(-))
Terraform Beta: Diff ( 142 files changed, 1974 insertions(+), 138 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-05-16T00:05:44Z

Tests analytics

Total tests: 2740
Passed tests 2450
Skipped tests: 283
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbCluster_missingLocation|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

modular-magician · 2023-05-16T00:07:46Z

Tests analytics

Total tests: 2740
Passed tests 2450
Skipped tests: 283
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbBackup_missingLocation|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

modular-magician · 2023-05-16T00:19:53Z

Tests passed during RECORDING mode:
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-05-16T00:21:30Z

Tests passed during RECORDING mode:
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-05-16T00:43:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 201 files changed, 5635 insertions(+), 127 deletions(-))
Terraform Beta: Diff ( 215 files changed, 5803 insertions(+), 138 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-05-16T01:37:32Z

Tests analytics

Total tests: 2740
Passed tests 2450
Skipped tests: 283
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbCluster_missingLocation|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example

Get to know how VCR tests work

modular-magician · 2023-05-16T01:51:36Z

Tests passed during RECORDING mode:
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

…odules into iam-datasources

… mmv1 metadata

modular-magician · 2023-05-18T01:01:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 239 files changed, 5726 insertions(+), 158 deletions(-))
Terraform Beta: Diff ( 253 files changed, 5894 insertions(+), 169 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-05-18T01:03:43Z

Tests analytics

Total tests: 12
Passed tests 12
Skipped tests: 0
Affected tests: 0

Errors occurred during REPLAYING mode. Please fix them to complete your PR
View the build log

modular-magician · 2023-05-18T01:26:01Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 239 files changed, 5726 insertions(+), 158 deletions(-))
Terraform Beta: Diff ( 253 files changed, 5894 insertions(+), 169 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-05-18T02:19:57Z

Tests analytics

Total tests: 2742
Passed tests 2433
Skipped tests: 283
Affected tests: 26

Action taken

Found 26 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccHealthcareFhirStoreIamPolicy|TestAccProjectIamPolicy_invalidMembers|TestAccKmsCryptoKeyIamPolicy|TestAccHealthcareDicomStoreIamPolicy|TestAccHealthcareDatasetIamPolicy|TestAccProjectIamPolicy_basic|TestAccSqlUser_postgresAbandon|TestAccSqlUser_postgres|TestAccSqlUser_postgresIAM|TestAccHealthcareHl7V2StoreIamPolicy|TestAccDataprocClusterIamPolicy|TestAccServiceAccountIamPolicy|TestAccDataprocJobIamPolicy|TestAccFolderIamPolicy_basic|TestAccContainerCluster_withDatabaseEncryption|TestAccComputeFirewallPolicyRule_multipleRules|TestAccPubsubSubscriptionIamPolicy|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccBigqueryDatasetIamPolicy|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccSpannerInstanceIamPolicy|TestAccSpannerDatabaseIamPolicy|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

modular-magician · 2023-05-18T02:47:13Z

Tests passed during RECORDING mode:
TestAccHealthcareFhirStoreIamPolicy[Debug log]
TestAccProjectIamPolicy_invalidMembers[Debug log]
TestAccKmsCryptoKeyIamPolicy[Debug log]
TestAccHealthcareDicomStoreIamPolicy[Debug log]
TestAccHealthcareDatasetIamPolicy[Debug log]
TestAccProjectIamPolicy_basic[Debug log]
TestAccSqlUser_postgresAbandon[Debug log]
TestAccSqlUser_postgres[Debug log]
TestAccSqlUser_postgresIAM[Debug log]
TestAccHealthcareHl7V2StoreIamPolicy[Debug log]
TestAccDataprocClusterIamPolicy[Debug log]
TestAccServiceAccountIamPolicy[Debug log]
TestAccDataprocJobIamPolicy[Debug log]
TestAccContainerCluster_withDatabaseEncryption[Debug log]
TestAccPubsubSubscriptionIamPolicy[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccBigqueryDatasetIamPolicy[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccSpannerInstanceIamPolicy[Debug log]
TestAccSpannerDatabaseIamPolicy[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

Tests failed during RECORDING mode:
TestAccFolderIamPolicy_basic[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-05-18T17:00:05Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 239 files changed, 5726 insertions(+), 158 deletions(-))
Terraform Beta: Diff ( 253 files changed, 5894 insertions(+), 169 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-05-18T17:52:48Z

Tests analytics

Total tests: 2743
Passed tests 2452
Skipped tests: 283
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccFolderIamPolicy_basic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

modular-magician · 2023-05-18T18:06:24Z

Tests passed during RECORDING mode:
TestAccFolderIamPolicy_basic[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

shuyama1

Overall LGTM. Only small comments

mmv1/templates/terraform/datasource_iam.html.markdown.erb

mmv1/templates/terraform/resource_iam.html.markdown.erb

mmv1/third_party/terraform/tests/resource_google_billing_account_iam_test.go

Co-authored-by: Shuya Ma <[email protected]>

…nt_iam_test.go Co-authored-by: Shuya Ma <[email protected]>

modular-magician · 2023-05-18T22:38:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 239 files changed, 5726 insertions(+), 158 deletions(-))
Terraform Beta: Diff ( 253 files changed, 5894 insertions(+), 169 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-05-18T23:34:46Z

Tests analytics

Total tests: 2743
Passed tests 2452
Skipped tests: 283
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccHealthcareHl7V2StoreIamPolicy|TestAccDataSourceAlloydbLocations_basic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbCluster_missingLocation|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example

Get to know how VCR tests work

modular-magician · 2023-05-18T23:48:14Z

Tests passed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccHealthcareHl7V2StoreIamPolicy[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2023-05-19T00:23:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 239 files changed, 5799 insertions(+), 158 deletions(-))
Terraform Beta: Diff ( 253 files changed, 5967 insertions(+), 169 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician · 2023-05-19T01:20:26Z

Tests analytics

Total tests: 2743
Passed tests 2452
Skipped tests: 283
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccProjectIamPolicy_invalidMembers|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbCluster_missingLocation|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

modular-magician · 2023-05-19T01:33:36Z

Tests passed during RECORDING mode:
TestAccProjectIamPolicy_invalidMembers[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

…7936) Co-authored-by: Shuya Ma <[email protected]>

add datasources for all iam_resources

a319445

ScottSuarez requested a review from rileykarson May 12, 2023 00:14

ScottSuarez requested review from a team and shuyama1 and removed request for rileykarson and a team May 12, 2023 15:24

ScottSuarez changed the title ~~add datasources for all iam_resources~~ add datasources for all generated iam_resources May 15, 2023

ScottSuarez added 2 commits May 15, 2023 15:30

Merge branch 'main' of https://github.com/GoogleCloudPlatform/magic-m…

759f239

…odules into iam-datasources

import name to terraform-provider-google/google

332d34e

GoogleCloudPlatform deleted a comment from modular-magician May 15, 2023

add documentation for datasource

c5011a4

ScottSuarez marked this pull request as draft May 16, 2023 21:42

ScottSuarez added 2 commits May 16, 2023 15:50

Merge branch 'main' of https://github.com/GoogleCloudPlatform/magic-m…

8a836b4

…odules into iam-datasources

remove examples.. cannot be supported due to availible information in…

dae9b5c

… mmv1 metadata

fix compilation issue

eb792e7

fix pubsub compilation issue

d4f843f

policy_data_test

c78ad09

ScottSuarez marked this pull request as ready for review May 18, 2023 17:20

shuyama1 approved these changes May 18, 2023

View reviewed changes

ScottSuarez and others added 3 commits May 18, 2023 15:19

Update mmv1/templates/terraform/datasource_iam.html.markdown.erb

f5ba44c

Co-authored-by: Shuya Ma <[email protected]>

Update mmv1/templates/terraform/resource_iam.html.markdown.erb

889e83b

Co-authored-by: Shuya Ma <[email protected]>

Update mmv1/third_party/terraform/tests/resource_google_billing_accou…

1d54e10

…nt_iam_test.go Co-authored-by: Shuya Ma <[email protected]>

Update resource_iam.html.markdown.erb

3206780

ScottSuarez merged commit b21e7cc into GoogleCloudPlatform:main May 19, 2023

ScottSuarez changed the title ~~add datasources for all generated iam_resources~~ add datasources for all iam_resources May 19, 2023

This was referenced May 19, 2023

add datasources for all iam_resources hashicorp/terraform-provider-google-beta#5661

Merged

add datasources for all iam_resources hashicorp/terraform-provider-google#14662

Merged

shourya116 pushed a commit to shourya116/magic-modules that referenced this pull request May 25, 2023

add datasources for all generated iam_resources (GoogleCloudPlatform#…

054e500

…7936) Co-authored-by: Shuya Ma <[email protected]>

ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023

add datasources for all generated iam_resources (GoogleCloudPlatform#…

b14b83f

…7936) Co-authored-by: Shuya Ma <[email protected]>

wj-chen pushed a commit to wj-chen/magic-modules that referenced this pull request Aug 1, 2023

add datasources for all generated iam_resources (GoogleCloudPlatform#…

ae25d11

…7936) Co-authored-by: Shuya Ma <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add datasources for all iam_resources #7936

add datasources for all iam_resources #7936

ScottSuarez commented May 12, 2023 •

edited

Loading

modular-magician commented May 12, 2023

rileykarson commented May 12, 2023

modular-magician commented May 12, 2023

modular-magician commented May 12, 2023

ScottSuarez commented May 12, 2023

ScottSuarez commented May 15, 2023

modular-magician commented May 15, 2023

modular-magician commented May 15, 2023

modular-magician commented May 16, 2023

modular-magician commented May 16, 2023

modular-magician commented May 16, 2023

modular-magician commented May 16, 2023

modular-magician commented May 16, 2023

modular-magician commented May 16, 2023

modular-magician commented May 16, 2023

modular-magician commented May 18, 2023

modular-magician commented May 18, 2023

modular-magician commented May 18, 2023

modular-magician commented May 18, 2023

modular-magician commented May 18, 2023

modular-magician commented May 18, 2023

modular-magician commented May 18, 2023

modular-magician commented May 18, 2023

shuyama1 left a comment

modular-magician commented May 18, 2023

modular-magician commented May 18, 2023

modular-magician commented May 18, 2023

modular-magician commented May 19, 2023

modular-magician commented May 19, 2023

modular-magician commented May 19, 2023

add datasources for all iam_resources #7936

add datasources for all iam_resources #7936

Conversation

ScottSuarez commented May 12, 2023 • edited Loading

modular-magician commented May 12, 2023

Diff report

rileykarson commented May 12, 2023

modular-magician commented May 12, 2023

Tests analytics

Action taken

modular-magician commented May 12, 2023

ScottSuarez commented May 12, 2023

ScottSuarez commented May 15, 2023

modular-magician commented May 15, 2023

Diff report

modular-magician commented May 15, 2023

Diff report

modular-magician commented May 16, 2023

Tests analytics

Action taken

modular-magician commented May 16, 2023

Tests analytics

Action taken

modular-magician commented May 16, 2023

modular-magician commented May 16, 2023

modular-magician commented May 16, 2023

Diff report

modular-magician commented May 16, 2023

Tests analytics

Action taken

modular-magician commented May 16, 2023

modular-magician commented May 18, 2023

Diff report

modular-magician commented May 18, 2023

Tests analytics

modular-magician commented May 18, 2023

Diff report

modular-magician commented May 18, 2023

Tests analytics

Action taken

modular-magician commented May 18, 2023

modular-magician commented May 18, 2023

Diff report

modular-magician commented May 18, 2023

Tests analytics

Action taken

modular-magician commented May 18, 2023

shuyama1 left a comment

Choose a reason for hiding this comment

modular-magician commented May 18, 2023

Diff report

modular-magician commented May 18, 2023

Tests analytics

Action taken

modular-magician commented May 18, 2023

modular-magician commented May 19, 2023

Diff report

modular-magician commented May 19, 2023

Tests analytics

Action taken

modular-magician commented May 19, 2023

ScottSuarez commented May 12, 2023 •

edited

Loading