Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding AuthorizedOrgsDesc to AccessContextManager #7178
Adding AuthorizedOrgsDesc to AccessContextManager #7178
Changes from 36 commits
009e34c
1662c19
5e20cb8
83c042b
3f54964
3d68146
6130b03
eb22b20
46b9105
ec65e59
873f448
5dc4370
267ab53
7dba1e3
2bc4090
62e8d21
7650978
8854d86
9c90499
de9b6a3
928fae0
5909a45
0781f74
844e88c
e3ec86d
792c2e4
ba738cf
56ae758
6f7c8c0
60818b0
1201f54
1119f49
c8f5d4b
e0a2386
98ad4ce
5478868
94134ba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a server-side default values for these fields -- Does API return values for them if they are not explicitly specified?
Also should we remove
*_UNSPECIFIED
values? My understanding is that they are not valid values for users to specify.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no server-side default values for
assetType
,authorizationDirection
, orauthorizationType
. The user must specify them.The
*_UNSPECIFIED
values exist under the hood, which is why I added them in the code here, but they cannot be used so IMO it's reasonable to remove them here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove these two fields as they may not be useful for Terraform users