Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for network_firewall_policy_association and region_network_firewall_policy_association #6796

Merged
merged 8 commits into from
Nov 11, 2022

Conversation

ghabian
Copy link
Contributor

@ghabian ghabian commented Nov 8, 2022

This PR adds support for the network_firewall_policy_association resource, and its regional counterpart (region_network_firewall_policy_association). These resources have been integrated into the DCL already and requires DCL v1.26 .

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_compute_network_firewall_policy_association`
`google_compute_region_network_firewall_policy_association`

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 1049 insertions(+), 31 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1051 insertions(+), 33 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2228
Passed tests 1985
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeRegionNetworkFirewallPolicyAssociation_RegionalHandWritten|TestAccComputeNetworkFirewallPolicyAssociation_GlobalHandWritten|TestAccFirebaserulesRelease_BasicRelease

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeRegionNetworkFirewallPolicyAssociation_RegionalHandWritten[Debug log]
TestAccComputeNetworkFirewallPolicyAssociation_GlobalHandWritten[Debug log]
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the id/import format, let's use a synthetic one over the format of the GET URL. That's consistent with other similar resources (we call this pattern "fine-grained resources"), particularly the FirewallPolicy suite of 'em.

Also left some newline suggestions, but that's just nitpicking. Feel free to make 'em in GitHub or locally. They're non-blocking.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 1057 insertions(+), 31 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1059 insertions(+), 33 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2230
Passed tests 1985
Skipped tests: 241
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccDataLossPreventionJobTrigger_dlpJobTriggerBasicExample|TestAccComputeNetworkFirewallPolicyAssociation_GlobalHandWritten|TestAccComputeRegionNetworkFirewallPolicyAssociation_RegionalHandWritten|TestAccComputeForwardingRule_update

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDataLossPreventionJobTrigger_dlpJobTriggerBasicExample[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccComputeNetworkFirewallPolicyAssociation_GlobalHandWritten[Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyAssociation_RegionalHandWritten[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 7 files changed, 1057 insertions(+), 31 deletions(-))
Terraform Beta: Diff ( 7 files changed, 1059 insertions(+), 33 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2237
Passed tests 1994
Skipped tests: 241
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccDataLossPreventionJobTrigger_dlpJobTriggerBasicExample|TestAccComputeForwardingRule_update

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDataLossPreventionJobTrigger_dlpJobTriggerBasicExample[Debug log]
TestAccComputeForwardingRule_update[Debug log]

All tests passed
View the build log or the debug log for each test

@ghabian
Copy link
Contributor Author

ghabian commented Nov 10, 2022

all set now @rileykarson ?

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

googlerjk pushed a commit to googlerjk/magic-modules that referenced this pull request Nov 25, 2022
…k_firewall_policy_association (GoogleCloudPlatform#6796)

Co-authored-by: Riley Karson <[email protected]>
Co-authored-by: Ghaleb Al-habian <[email protected]>
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Dec 6, 2022
…k_firewall_policy_association (GoogleCloudPlatform#6796)

Co-authored-by: Riley Karson <[email protected]>
Co-authored-by: Ghaleb Al-habian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants