Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlloyDB Instance #6792

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Nov 7, 2022

Part of hashicorp/terraform-provider-google#11754
Resuming #6208

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_alloydb_instance`

@c2thorn c2thorn mentioned this pull request Nov 7, 2022
5 tasks
@c2thorn
Copy link
Member Author

c2thorn commented Nov 7, 2022

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 206 insertions(+))
Terraform Beta: Diff ( 6 files changed, 1314 insertions(+), 2 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 145 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2218
Passed tests 1977
Skipped tests: 239
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccAlloydbInstance_update|TestAccAlloydbInstance_alloydbInstanceBasicExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccAlloydbInstance_update[Debug log]
TestAccAlloydbInstance_alloydbInstanceBasicExample[Debug log]

All tests passed
View the build log or the debug log for each test

Copy link
Member Author

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melinath this is a continuation of the PR prepared by @DrFaust92

The primary difference here is the the replacement of projects/{project}/locations/{location}/clusters/{cluster_id} for just a {cluster} parent reference in the self link

@c2thorn c2thorn requested a review from melinath November 7, 2022 21:14
Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c2thorn c2thorn merged commit 0e4210c into GoogleCloudPlatform:main Nov 8, 2022
@c2thorn c2thorn deleted the alloy-db-instance branch November 8, 2022 21:28
@melinath
Copy link
Member

melinath commented Nov 8, 2022

Ideally it would be good to have a full test additionally - i.e. exercising gceZone, machineConfig, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants