Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network_services: Dual-Token Authentication Support #6751

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

carlyeks
Copy link
Contributor

@carlyeks carlyeks commented Oct 28, 2022

Adds signed_token_options and add_signatures field to google_network_services_edge_cache_service and validation_shared_keys to google_network_services_edge_cache_keyset to support dual-token authentication.
Resolves hashicorp/terraform-provider-google#12775.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

network_services: added `signed_token_options` and `add_signatures` field to `google_network_services_edge_cache_service` and `validation_shared_keys` to `google_network_services_edge_cache_keyset` to support dual-token authentication

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @shuyama1, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 955 insertions(+), 39 deletions(-))
Terraform Beta: Diff ( 6 files changed, 955 insertions(+), 39 deletions(-))
TF Validator: Diff ( 4 files changed, 172 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 342 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2212
Passed tests 1970
Skipped tests: 239
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccComputeForwardingRule_update|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceDualTokenExample|TestAccNetworkServicesEdgeCacheKeyset_networkServicesEdgeCacheKeysetDualTokenExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeForwardingRule_update[Debug log]
TestAccNetworkServicesEdgeCacheKeyset_networkServicesEdgeCacheKeysetDualTokenExample[Debug log]

Tests failed during RECORDING mode:
TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceDualTokenExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@carlyeks
Copy link
Contributor Author

carlyeks commented Nov 4, 2022

@shuyama1 Can you take a look at this PR? I believe the test failure is transient.

@shuyama1
Copy link
Member

shuyama1 commented Nov 4, 2022

@carlyeks Are you able to get the test passed locally?

@carlyeks
Copy link
Contributor Author

carlyeks commented Nov 4, 2022

Yes, I was able to get this test to pass locally:

TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google -run=TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceDualTokenExample -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
ok      github.com/hashicorp/terraform-provider-google/google   502.329s

@shuyama1
Copy link
Member

shuyama1 commented Nov 8, 2022

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 955 insertions(+), 39 deletions(-))
Terraform Beta: Diff ( 6 files changed, 955 insertions(+), 39 deletions(-))
TF Validator: Diff ( 4 files changed, 172 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 342 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2227
Passed tests 1984
Skipped tests: 240
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests
TestAccFirebaserulesRelease_BasicRelease|TestAccComputeForwardingRule_update|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceDualTokenExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeForwardingRule_update[Debug log]
TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceDualTokenExample[Debug log]

All tests passed
View the build log or the debug log for each test

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall! Do you happen to know if any of the added fields are immutable that can't be updated after creation?

@carlyeks
Copy link
Contributor Author

No; these are all mutable fields.

@carlyeks
Copy link
Contributor Author

@shuyama1: could you take another look at this?

Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_network_services: Add support for dual-token authentication
3 participants