-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bq capacity commitment #6690
Bq capacity commitment #6690
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 5 files changed, 747 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccBigqueryReservationReservationCapacityCommitment_bigqueryReservationCapacityCommitmentBasicExample |
Tests failed during RECORDING mode: Please fix these to complete your PR |
Test fails with Error: Error creating ReservationCapacityCommitment: googleapi: Error 400: slot_count must be positive. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 5 files changed, 743 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccBigqueryReservationReservationCapacityCommitment_bigqueryReservationCapacityCommitmentBasicExample |
Tests failed during RECORDING mode: Please fix these to complete your PR |
Failing with: Looks like slot_count isn't coming back from the API or something like that? Are you seeing this pass locally? |
@slevenick have an issue testing as it might incur very high costs /: |
Yeah, can you change the slot_count to 1? I'm assuming that makes this more or less expensive to run in CI. I looked at the logs, it seems like we need to change We are currently creating with no commitment ID, so it gets a random one and then we don't call GET correctly. |
Closes hashicorp/terraform-provider-google#6694
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)