Bq capacity commitment

[DrFaust92]

Closes hashicorp/terraform-provider-google#6694

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_bigquery_reservation_capacity_commitment

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 747 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 747 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 96 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 109 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2198
Passed tests 1958
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBigqueryReservationReservationCapacityCommitment_bigqueryReservationCapacityCommitmentBasicExample

[modular-magician]

Tests failed during RECORDING mode:
TestAccBigqueryReservationReservationCapacityCommitment_bigqueryReservationCapacityCommitmentBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[slevenick]

Test fails with Error: Error creating ReservationCapacityCommitment: googleapi: Error 400: slot_count must be positive.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 743 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 743 insertions(+), 2 deletions(-))
TF Validator: Diff ( 3 files changed, 96 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 4 files changed, 107 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2197
Passed tests 1957
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBigqueryReservationReservationCapacityCommitment_bigqueryReservationCapacityCommitmentBasicExample

[modular-magician]

Tests failed during RECORDING mode:
TestAccBigqueryReservationReservationCapacityCommitment_bigqueryReservationCapacityCommitmentBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[slevenick]

Failing with:
# google_bigquery_reservation_capacity_commitment.commitment will be updated in-place
~ resource "google_bigquery_reservation_capacity_commitment" "commitment" {
+ plan = "FLEX"
~ slot_count = 0 -> 100
# (4 unchanged attributes hidden)
}

Looks like slot_count isn't coming back from the API or something like that? Are you seeing this pass locally?

[DrFaust92]

@slevenick have an issue testing as it might incur very high costs /:

[slevenick]

@slevenick have an issue testing as it might incur very high costs /:

Yeah, can you change the slot_count to 1? I'm assuming that makes this more or less expensive to run in CI.

I looked at the logs, it seems like we need to change create_url: projects/{{project}}/locations/{{location}}/capacityCommitments?capacityCommitmentId={{capacityCommitmentId}} -> create_url: projects/{{project}}/locations/{{location}}/capacityCommitments?capacityCommitmentId={{capacity_commitment_id}}

We are currently creating with no commitment ID, so it gets a random one and then we don't call GET correctly.