Support BigQuery authorized routines #6680
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| resource "google_bigquery_dataset" "public" { | ||
| dataset_id = "<%= ctx[:vars]['public'] %>" | ||
| description = "This dataset is public" | ||
| } | ||
|
|
||
| resource "google_bigquery_routine" "public" { | ||
| dataset_id = google_bigquery_dataset.public.dataset_id | ||
| routine_id = "sample_routine" | ||
|
There was a problem hiding this comment. Is this automatically deleted if the dataset is deleted? And/or is there any issue with quotas for this resource, or name conflicts if parallel test runs happen at the same time? Otherwise it might be worth making this use a var as well. |
||
| routine_type = "TABLE_VALUED_FUNCTION" | ||
| language = "SQL" | ||
| definition_body = <<-EOS | ||
| SELECT 1 + value AS value | ||
| EOS | ||
| arguments { | ||
| name = "value" | ||
| argument_kind = "FIXED_TYPE" | ||
| data_type = jsonencode({ "typeKind" = "INT64" }) | ||
| } | ||
| return_table_type = jsonencode({ "columns" = [ | ||
| { "name" = "value", "type" = { "typeKind" = "INT64" } }, | ||
| ] }) | ||
| } | ||
|
|
||
| resource "google_bigquery_dataset" "private" { | ||
| dataset_id = "<%= ctx[:vars]['private'] %>" | ||
| description = "This dataset is private" | ||
| } | ||
|
|
||
| resource "google_bigquery_dataset_access" "authorized_routine" { | ||
| dataset_id = google_bigquery_dataset.private.dataset_id | ||
| routine { | ||
| project_id = google_bigquery_routine.public.project | ||
| dataset_id = google_bigquery_routine.public.dataset_id | ||
| routine_id = google_bigquery_routine.public.routine_id | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| resource "google_bigquery_dataset" "public" { | ||
| dataset_id = "<%= ctx[:vars]['public'] %>" | ||
| description = "This dataset is public" | ||
| } | ||
|
|
||
| resource "google_bigquery_routine" "public" { | ||
| dataset_id = google_bigquery_dataset.public.dataset_id | ||
| routine_id = "sample_routine" | ||
| routine_type = "TABLE_VALUED_FUNCTION" | ||
| language = "SQL" | ||
| definition_body = <<-EOS | ||
| SELECT 1 + value AS value | ||
| EOS | ||
| arguments { | ||
| name = "value" | ||
| argument_kind = "FIXED_TYPE" | ||
| data_type = jsonencode({ "typeKind" = "INT64" }) | ||
| } | ||
| return_table_type = jsonencode({ "columns" = [ | ||
| { "name" = "value", "type" = { "typeKind" = "INT64" } }, | ||
| ] }) | ||
| } | ||
|
|
||
| resource "google_bigquery_dataset" "private" { | ||
| dataset_id = "<%= ctx[:vars]['private'] %>" | ||
| description = "This dataset is private" | ||
| access { | ||
| role = "WRITER" | ||
| specialGroup = "projectWriters" | ||
|
There was a problem hiding this comment. this would need to be There was a problem hiding this comment. @melinath On the other hands, I'm worried about the failed test. |
||
| } | ||
| access { | ||
| role = "OWNER" | ||
| specialGroup = "projectOwners" | ||
| } | ||
| access { | ||
| role = "OWNER" | ||
| user_by_email = "<%= ctx[:test_env_vars]['service_account'] %>" | ||
| } | ||
| access { | ||
| role = "READER" | ||
| specialGroup = "projectReaders" | ||
| } | ||
| access { | ||
| routine { | ||
| project_id = google_bigquery_routine.public.project | ||
| dataset_id = google_bigquery_routine.public.dataset_id | ||
| routine_id = google_bigquery_routine.public.routine_id | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to match the second part of a
datasetresource's terraform id. For example, for:the resource address is
google_bigquery_dataset.public, so primary_resource_id would need to bepublic.The "primary resource" will be imported as part of the test. In this case, the important thing is to make sure that imports work correctly for the
routinefield (which is on theprivatedataset)