Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix documentai so eu region is supported #6229

Merged
merged 2 commits into from
Jul 11, 2022

Conversation

ScottSuarez
Copy link
Contributor

@ScottSuarez ScottSuarez commented Jul 6, 2022

closes hashicorp/terraform-provider-google#12015
Release Note Template for Downstream PRs (will be copied)

documentai: fixed bug where eu region could not be utilized for documentai resources

@ScottSuarez ScottSuarez requested review from a team and shuyama1 and removed request for a team July 6, 2022 22:04
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 5 files changed, 58 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 5 files changed, 58 insertions(+), 12 deletions(-))
TF Validator: Diff ( 5 files changed, 10 insertions(+), 10 deletions(-))
TF OiCS: Diff ( 4 files changed, 106 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2089
Passed tests 1857
Skipped tests: 226
Failed tests: 6

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccFirebaserulesRelease_BasicRelease|TestAccDocumentAIProcessor_documentaiProcessorEuExample|TestAccDocumentAIProcessor_documentaiProcessorExample|TestAccDocumentAIProcessorDefaultVersion_documentaiDefaultVersionExample|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDocumentAIProcessor_documentaiProcessorEuExample[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccDocumentAIProcessor_documentaiProcessorExample[view]

Tests failed during RECORDING mode:
TestAccDocumentAIProcessorDefaultVersion_documentaiDefaultVersionExample[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@shuyama1
Copy link
Member

shuyama1 commented Jul 7, 2022

Looks like test TestAccDocumentAIProcessorDefaultVersion_documentaiDefaultVersionExample failed.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 7 files changed, 87 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 7 files changed, 87 insertions(+), 16 deletions(-))
TF Validator: Diff ( 5 files changed, 10 insertions(+), 10 deletions(-))
TF OiCS: Diff ( 4 files changed, 106 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2092
Passed tests 1862
Skipped tests: 226
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccFirebaserulesRelease_BasicRelease|TestAccDocumentAIProcessorDefaultVersion_documentaiDefaultVersionExample|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDocumentAIProcessorDefaultVersion_documentaiDefaultVersionExample[view]
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccFirebaserulesRelease_BasicRelease[view]

All tests passed
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_document_ai_processor resource fails when setting the "eu" location.
3 participants