Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add https_trigger_security_level to cloudfunction_function #6007

Merged
merged 2 commits into from
May 9, 2022

Conversation

megan07
Copy link
Contributor

@megan07 megan07 commented May 5, 2022

Fixes hashicorp/terraform-provider-google#11086

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudfunctions: added `https_trigger_security_level` to `google_cloudfunctions_function`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 27 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 2 files changed, 27 insertions(+), 10 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2008
Passed tests 1749
Skipped tests: 242
Failed tests: 17

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample|TestAccCloudFunctionsFunction_firestore|TestAccCloudFunctionsFunction_dockerRepository|TestAccCloudFunctionsFunction_cmek|TestAccCloudFunctionsFunction_secretMount|TestAccCloudFunctionsFunction_bucket|TestAccCloudFunctionsFunction_pubsub|TestAccCloudFunctionsFunction_update|TestAccCloudFunctionsFunction_basic|TestAccCloudFunctionsFunction_secretEnvVar|TestAccCloudFunctionsFunction_vpcConnector|TestAccCloudFunctionsFunction_serviceAccountEmail|TestAccCloudFunctionsFunction_sourceRepo|TestAccCloudFunctionsCloudFunctionIamMemberGenerated|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccCloudFunctionsCloudFunctionIamBindingGenerated|TestAccCloudFunctionsCloudFunctionIamPolicyGenerated

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDataSourceGoogleCloudFunctionsFunction_basic[view]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample[view]
TestAccCloudFunctionsFunction_secretMount[view]
TestAccCloudFunctionsFunction_secretEnvVar[view]
TestAccCloudFunctionsFunction_sourceRepo[view]
TestAccCloudFunctionsFunction_update[view]
TestAccCloudFunctionsFunction_dockerRepository[view]
TestAccCloudFunctionsCloudFunctionIamPolicyGenerated[view]
TestAccCloudFunctionsFunction_basic[view]
TestAccCloudFunctionsCloudFunctionIamMemberGenerated[view]
TestAccCloudFunctionsCloudFunctionIamBindingGenerated[view]

Tests failed during RECORDING mode:
TestAccCloudFunctionsFunction_cmek[view]
TestAccCloudFunctionsFunction_vpcConnector[view]
TestAccCloudFunctionsFunction_serviceAccountEmail[view]
TestAccCloudFunctionsFunction_firestore[view]
TestAccCloudFunctionsFunction_bucket[view]
TestAccCloudFunctionsFunction_pubsub[view]

Please fix these to complete your PR
View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 27 insertions(+), 10 deletions(-))
Terraform Beta: Diff ( 2 files changed, 27 insertions(+), 10 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2008
Passed tests 1754
Skipped tests: 242
Failed tests: 12

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample|TestAccCloudFunctionsFunction_secretMount|TestAccCloudFunctionsFunction_secretEnvVar|TestAccCloudFunctionsFunction_sourceRepo|TestAccCloudFunctionsFunction_dockerRepository|TestAccCloudFunctionsFunction_update|TestAccCloudFunctionsFunction_basic|TestAccFirebaserulesRelease_BasicRelease|TestAccCloudFunctionsCloudFunctionIamPolicyGenerated|TestAccCloudFunctionsCloudFunctionIamMemberGenerated|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccCloudFunctionsCloudFunctionIamBindingGenerated

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDataSourceGoogleCloudFunctionsFunction_basic[view]
TestAccCloudFunctionsFunction_sourceRepo[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample[view]
TestAccCloudFunctionsFunction_secretMount[view]
TestAccCloudFunctionsFunction_secretEnvVar[view]
TestAccCloudFunctionsFunction_basic[view]
TestAccCloudFunctionsFunction_dockerRepository[view]
TestAccCloudFunctionsFunction_update[view]
TestAccCloudFunctionsCloudFunctionIamMemberGenerated[view]
TestAccCloudFunctionsCloudFunctionIamPolicyGenerated[view]
TestAccCloudFunctionsCloudFunctionIamBindingGenerated[view]

All tests passed
View the build log or the debug log for each test

@megan07 megan07 requested review from c2thorn and shuyama1 and removed request for c2thorn May 5, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpsTrigger on CloudFunctions
3 participants