-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add https_trigger_security_level to cloudfunction_function #6007
Conversation
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 27 insertions(+), 10 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample|TestAccCloudFunctionsFunction_firestore|TestAccCloudFunctionsFunction_dockerRepository|TestAccCloudFunctionsFunction_cmek|TestAccCloudFunctionsFunction_secretMount|TestAccCloudFunctionsFunction_bucket|TestAccCloudFunctionsFunction_pubsub|TestAccCloudFunctionsFunction_update|TestAccCloudFunctionsFunction_basic|TestAccCloudFunctionsFunction_secretEnvVar|TestAccCloudFunctionsFunction_vpcConnector|TestAccCloudFunctionsFunction_serviceAccountEmail|TestAccCloudFunctionsFunction_sourceRepo|TestAccCloudFunctionsCloudFunctionIamMemberGenerated|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccCloudFunctionsCloudFunctionIamBindingGenerated|TestAccCloudFunctionsCloudFunctionIamPolicyGenerated |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 2 files changed, 27 insertions(+), 10 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupFunctionsExample|TestAccCloudFunctionsFunction_secretMount|TestAccCloudFunctionsFunction_secretEnvVar|TestAccCloudFunctionsFunction_sourceRepo|TestAccCloudFunctionsFunction_dockerRepository|TestAccCloudFunctionsFunction_update|TestAccCloudFunctionsFunction_basic|TestAccFirebaserulesRelease_BasicRelease|TestAccCloudFunctionsCloudFunctionIamPolicyGenerated|TestAccCloudFunctionsCloudFunctionIamMemberGenerated|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccCloudFunctionsCloudFunctionIamBindingGenerated |
Tests passed during RECORDING mode: All tests passed |
Fixes hashicorp/terraform-provider-google#11086
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)