Fix DSF on firewall source_ranges

[slevenick]

Fixes: hashicorp/terraform-provider-google#10496

I mixed up how to correctly suppress the diff, and tried to compare to the old value within the function.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: fixed a bug in `google_compute_firewall` that would cause changes in `source_ranges` to not correctly be applied

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
TF Validator: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))

[slevenick]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
TF Validator: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))

[slevenick]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
TF Validator: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))

[slevenick]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
TF Validator: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccPubsubTopicIamBindingGenerated|TestAccPubsubTopicIamMemberGenerated|TestAccPubsubTopicIamPolicyGenerated|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeForwardingRule_update|TestAccComputeInstanceFromMachineImage_basic|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccComputeInstanceFromMachineImage_diffProject|TestAccRegionInstanceGroupManager_stateful|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccComputeRegionPerInstanceConfig_update|TestAccLoggingProjectSink_described_update|TestAccPubsubTopic_pubsubTopicBasicExample|TestAccSqlUser_postgresIAM|TestAccTags You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=216148