Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DSF on firewall source_ranges #5427

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

slevenick
Copy link
Contributor

Fixes: hashicorp/terraform-provider-google#10496

I mixed up how to correctly suppress the diff, and tried to compare to the old value within the function.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: fixed a bug in `google_compute_firewall` that would cause changes in `source_ranges` to not correctly be applied

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
TF Validator: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))

@slevenick
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
TF Validator: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))

@slevenick
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
TF Validator: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))

@slevenick
Copy link
Contributor Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))
TF Validator: Diff ( 1 file changed, 4 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccPubsubTopicIamBindingGenerated|TestAccPubsubTopicIamMemberGenerated|TestAccPubsubTopicIamPolicyGenerated|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeForwardingRule_update|TestAccComputeInstanceFromMachineImage_basic|TestAccComputeInstanceFromMachineImage_overrideMetadataDotStartupScript|TestAccComputeInstanceFromMachineImage_diffProject|TestAccRegionInstanceGroupManager_stateful|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccComputeRegionPerInstanceConfig_update|TestAccLoggingProjectSink_described_update|TestAccPubsubTopic_pubsubTopicBasicExample|TestAccSqlUser_postgresIAM|TestAccTags You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=216148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcp_compute_firewall source_ranges is never deleted (in favor of source_tags)
3 participants