-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
self_link 4.0.0 changes #5314
self_link 4.0.0 changes #5314
Conversation
mmv1/third_party/terraform/website/docs/guides/version_4_upgrade.html.markdown
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/guides/version_4_upgrade.html.markdown
Show resolved
Hide resolved
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleKmsCryptoKey_basic|TestAccDataSourceGoogleKmsKeyRing_basic|TestAccCloudFunctionsFunction_vpcConnector|TestAccContainerAnalysisOccurrence_basic|TestAccContainerAnalysisOccurrence_multipleSignatures|TestAccKmsCryptoKey_basic|TestAccKmsCryptoKey_template|TestAccKmsCryptoKey_destroyDuration|TestAccKmsCryptoKey_importOnly|TestAccPubsubSubscription_update You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=210259 |
/gcbrun |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleKmsCryptoKey_basic|TestAccDataSourceGoogleKmsKeyRing_basic|TestAccCloudFunctionsFunction_vpcConnector|TestAccContainerAnalysisOccurrence_basic|TestAccContainerAnalysisOccurrence_multipleSignatures|TestAccContainerCluster_withAddons|TestAccContainerCluster_withWorkloadIdentityConfigDeprecation|TestAccContainerCluster_withWorkloadIdentityConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=210675 |
Tests failed during RECORDING mode: TestAccContainerAnalysisOccurrence_basic|TestAccContainerAnalysisOccurrence_multipleSignatures|TestAccDataSourceGoogleKmsCryptoKey_basic|TestAccDataSourceGoogleKmsKeyRing_basic|TestAccCloudFunctionsFunction_vpcConnector Please fix these to complete your PR |
Looks like some references and test checks still need to be removed |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleKmsKeyRing_basic|TestAccIapTunnelIamPolicyGenerated|TestAccCloudFunctionsFunction_vpcConnector|TestAccContainerAnalysisOccurrence_basic|TestAccContainerAnalysisOccurrence_multipleSignatures You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=210881 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming tests are/will be fixed
/gcbrun |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeForwardingRule_update|TestAccContainerAnalysisOccurrence_multipleSignatures|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211696 |
Tests failed during RECORDING mode: TestAccContainerAnalysisOccurrence_multipleSignatures|TestAccSqlUser_postgresIAM|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccCloudFunctionsFunction_vpcConnector Please fix these to complete your PR |
Fixes: hashicorp/terraform-provider-google#8276
Fixes: hashicorp/terraform-provider-google#8275
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)