self_link 4.0.0 changes

[slevenick]

Fixes: hashicorp/terraform-provider-google#8276
Fixes: hashicorp/terraform-provider-google#8275

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

pubsub: removed `path` field from `google_pubsub_subscription`

kms: removed `self_link` field from `google_kms_crypto_key` and `google_kms_key_ring`

compute: removed `source_disk_link` field from `google_compute_snapshot`

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 13 files changed, 31 insertions(+), 103 deletions(-))
Terraform Beta: Diff ( 13 files changed, 31 insertions(+), 103 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleKmsCryptoKey_basic|TestAccDataSourceGoogleKmsKeyRing_basic|TestAccCloudFunctionsFunction_vpcConnector|TestAccContainerAnalysisOccurrence_basic|TestAccContainerAnalysisOccurrence_multipleSignatures|TestAccKmsCryptoKey_basic|TestAccKmsCryptoKey_template|TestAccKmsCryptoKey_destroyDuration|TestAccKmsCryptoKey_importOnly|TestAccPubsubSubscription_update You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=210259

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 22 files changed, 46 insertions(+), 121 deletions(-))
Terraform Beta: Diff ( 26 files changed, 50 insertions(+), 126 deletions(-))

[slevenick]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 23 files changed, 47 insertions(+), 122 deletions(-))
Terraform Beta: Diff ( 26 files changed, 50 insertions(+), 125 deletions(-))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 22 files changed, 46 insertions(+), 122 deletions(-))
Terraform Beta: Diff ( 26 files changed, 50 insertions(+), 126 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleKmsCryptoKey_basic|TestAccDataSourceGoogleKmsKeyRing_basic|TestAccCloudFunctionsFunction_vpcConnector|TestAccContainerAnalysisOccurrence_basic|TestAccContainerAnalysisOccurrence_multipleSignatures|TestAccContainerCluster_withAddons|TestAccContainerCluster_withWorkloadIdentityConfigDeprecation|TestAccContainerCluster_withWorkloadIdentityConfig You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=210675

[modular-magician]

Tests failed during RECORDING mode: TestAccContainerAnalysisOccurrence_basic|TestAccContainerAnalysisOccurrence_multipleSignatures|TestAccDataSourceGoogleKmsCryptoKey_basic|TestAccDataSourceGoogleKmsKeyRing_basic|TestAccCloudFunctionsFunction_vpcConnector Please fix these to complete your PR

[c2thorn]

Looks like some references and test checks still need to be removed

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 24 files changed, 49 insertions(+), 125 deletions(-))
Terraform Beta: Diff ( 28 files changed, 53 insertions(+), 129 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceGoogleKmsKeyRing_basic|TestAccIapTunnelIamPolicyGenerated|TestAccCloudFunctionsFunction_vpcConnector|TestAccContainerAnalysisOccurrence_basic|TestAccContainerAnalysisOccurrence_multipleSignatures You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=210881

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 25 files changed, 58 insertions(+), 126 deletions(-))
Terraform Beta: Diff ( 28 files changed, 61 insertions(+), 129 deletions(-))

[c2thorn]

LGTM assuming tests are/will be fixed

[slevenick]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 25 files changed, 58 insertions(+), 126 deletions(-))
Terraform Beta: Diff ( 29 files changed, 62 insertions(+), 130 deletions(-))

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccCloudFunctionsFunction_vpcConnector|TestAccComputeForwardingRule_update|TestAccContainerAnalysisOccurrence_multipleSignatures|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSqlUser_postgresIAM You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=211696

[modular-magician]

Tests failed during RECORDING mode: TestAccContainerAnalysisOccurrence_multipleSignatures|TestAccSqlUser_postgresIAM|TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccCloudFunctionsFunction_vpcConnector Please fix these to complete your PR

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 23 files changed, 52 insertions(+), 79 deletions(-))
Terraform Beta: Diff ( 27 files changed, 56 insertions(+), 83 deletions(-))