Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to containers to support DCL's build - open up test to work on more repos. #5238

Merged
merged 3 commits into from
Sep 24, 2021

Conversation

nat-henderson
Copy link
Contributor

Should be a no-op for this repo. terraform-tester is backwards compatible on purpose.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable but there are a couple more references to magic-modules in the test_terraform.sh file that should be replaced. Also, could you whitelist this PR to run the ci pipeline?

@nat-henderson
Copy link
Contributor Author

Sure - but I will have to push the container before I do it, because it modifies that yaml file. Is that okay with you? Risk if I've got it wrong is that tests might fail.

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mm. Up to you. LGTM

@nat-henderson
Copy link
Contributor Author

Went ahead and did it, /gcbrun

@nat-henderson
Copy link
Contributor Author

Ah, it doesn't work because this doesn't touch the right files. That's fine, I'll push a tiny dummy change.

@nat-henderson
Copy link
Contributor Author

Yep, works. will merge.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 3 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 3 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginBasicExample|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginAdvancedExample|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceAdvancedExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=207365

khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
…n more repos. (GoogleCloudPlatform#5238)

* Changes to containers to support DCL's build - open up test to work on multiple repos.

* replace remaining magic-modules references

* upgrade dcl.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants