-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to containers to support DCL's build - open up test to work on more repos. #5238
Conversation
…n multiple repos.
5c45121
to
1508570
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable but there are a couple more references to magic-modules in the test_terraform.sh file that should be replaced. Also, could you whitelist this PR to run the ci pipeline?
Sure - but I will have to push the container before I do it, because it modifies that yaml file. Is that okay with you? Risk if I've got it wrong is that tests might fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mm. Up to you. LGTM
Went ahead and did it, /gcbrun |
Ah, it doesn't work because this doesn't touch the right files. That's fine, I'll push a tiny dummy change. |
Yep, works. will merge. |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginBasicExample|TestAccNetworkServicesEdgeCacheOrigin_networkServicesEdgeCacheOriginAdvancedExample|TestAccNetworkServicesEdgeCacheService_networkServicesEdgeCacheServiceAdvancedExample You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=207365 |
…n more repos. (GoogleCloudPlatform#5238) * Changes to containers to support DCL's build - open up test to work on multiple repos. * replace remaining magic-modules references * upgrade dcl.
Should be a no-op for this repo.
terraform-tester
is backwards compatible on purpose.If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)