Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name to google_kms_crypto_key_version datasource #5065

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

upodroid
Copy link
Contributor

@upodroid upodroid commented Aug 9, 2021

Fixes: hashicorp/terraform-provider-google#9729

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

kms: added `name` field to `google_kms_crypto_key_version` datasource

@google-cla google-cla bot added the cla: yes label Aug 9, 2021
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@c2thorn, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 17 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 2 files changed, 17 insertions(+), 3 deletions(-))

@c2thorn
Copy link
Member

c2thorn commented Aug 9, 2021

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 17 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 18 insertions(+), 5 deletions(-))

@c2thorn
Copy link
Member

c2thorn commented Aug 10, 2021

/gcbrun

@modular-magician
Copy link
Collaborator

Error trying to cancel build ()

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 17 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 2 files changed, 17 insertions(+), 3 deletions(-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add "name" as an attribute to the data source: kms_crypto_key_version
3 participants