Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppressed binary authorization attestor key signature algorithm diffs if the algorithms are equivalent #4575

Conversation

melinath
Copy link
Member

@melinath melinath commented Mar 9, 2021

Resolved hashicorp/terraform-provider-google#8511. Suppressed binary authorization attestor key signature algorithm diffs if the algorithms are equivalent; different ways of getting this key seem to provide different (but equivalent) results.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

binaryauthorization: fixed permadiff in `google_binary_authorization_attestor`

@google-cla google-cla bot added the cla: yes label Mar 9, 2021
@melinath melinath requested review from a team, nat-henderson and ScottSuarez and removed request for a team and nat-henderson March 9, 2021 19:05
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 72 insertions(+))
Terraform Beta: Diff ( 3 files changed, 73 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 30 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=176359"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=176380"

@modular-magician
Copy link
Collaborator

Tests failed during RECORDING mode: TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated Please fix these to complete your PR

@melinath
Copy link
Member Author

melinath commented Mar 9, 2021

Test failure is unrelated

@melinath melinath merged commit 7bab503 into GoogleCloudPlatform:master Mar 9, 2021
@melinath melinath deleted the tpg-8511-attestor-algorithm-permadiff branch March 9, 2021 21:15
melinath added a commit that referenced this pull request Apr 22, 2022
melinath added a commit that referenced this pull request May 19, 2022
* Made diff_suppress_func for signature algorithm actually get used

Originally introduced in #4575

* Renamed test files to match autogenerated files
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request May 19, 2022
)

* Made diff_suppress_func for signature algorithm actually get used

Originally introduced in GoogleCloudPlatform/magic-modules#4575

* Renamed test files to match autogenerated files

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this pull request May 19, 2022
)

* Made diff_suppress_func for signature algorithm actually get used

Originally introduced in GoogleCloudPlatform/magic-modules#4575

* Renamed test files to match autogenerated files

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to hashicorp/terraform-provider-google that referenced this pull request May 19, 2022
)

* Made diff_suppress_func for signature algorithm actually get used

Originally introduced in GoogleCloudPlatform/magic-modules#4575

* Renamed test files to match autogenerated files

Signed-off-by: Modular Magician <[email protected]>
modular-magician added a commit to hashicorp/terraform-provider-google-beta that referenced this pull request May 19, 2022
* Made diff_suppress_func for signature algorithm actually get used

Originally introduced in GoogleCloudPlatform/magic-modules#4575

* Renamed test files to match autogenerated files

Signed-off-by: Modular Magician <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permadiff in google_binary_authorization_attestor
3 participants