-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppressed binary authorization attestor key signature algorithm diffs if the algorithms are equivalent #4575
Suppressed binary authorization attestor key signature algorithm diffs if the algorithms are equivalent #4575
Conversation
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=176359" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=176380" |
Tests failed during RECORDING mode: TestAccApiGatewayGateway_apigatewayGatewayBasicExampleUpdated Please fix these to complete your PR |
Test failure is unrelated |
Originally introduced in #4575
* Made diff_suppress_func for signature algorithm actually get used Originally introduced in #4575 * Renamed test files to match autogenerated files
) * Made diff_suppress_func for signature algorithm actually get used Originally introduced in GoogleCloudPlatform/magic-modules#4575 * Renamed test files to match autogenerated files Signed-off-by: Modular Magician <[email protected]>
) * Made diff_suppress_func for signature algorithm actually get used Originally introduced in GoogleCloudPlatform/magic-modules#4575 * Renamed test files to match autogenerated files Signed-off-by: Modular Magician <[email protected]>
) * Made diff_suppress_func for signature algorithm actually get used Originally introduced in GoogleCloudPlatform/magic-modules#4575 * Renamed test files to match autogenerated files Signed-off-by: Modular Magician <[email protected]>
* Made diff_suppress_func for signature algorithm actually get used Originally introduced in GoogleCloudPlatform/magic-modules#4575 * Renamed test files to match autogenerated files Signed-off-by: Modular Magician <[email protected]>
Resolved hashicorp/terraform-provider-google#8511. Suppressed binary authorization attestor key signature algorithm diffs if the algorithms are equivalent; different ways of getting this key seem to provide different (but equivalent) results.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)