Export email output in service_identity

[umairidris]

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_project_service_identity: add `email` output.

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@slevenick, please review this PR or find an appropriate assignee.

[umairidris]

cc @rileykarson

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 9 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 34 insertions(+), 16 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142803"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 9 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 34 insertions(+), 16 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142806"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeDisk_VSSWindows You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142812"

[umairidris]

I tested this by building the provider and using it in a real config.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 9 insertions(+), 7 deletions(-))
Terraform Beta: Diff ( 3 files changed, 32 insertions(+), 16 deletions(-))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=143062"

[slevenick]

If the response doesn't contain an email should we fail during the create method? Is returning the generated email a requirement of this request succeeding?

[umairidris]

Based on the API we should always get an email in the response, so I think it's safe to fail if it's missing.

The "right" way to implement this would be to call a READ endpoint, but there is none for this API.

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeDisk_VSSWindows You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=143064"

[umairidris]

FYI this is required for terraform-google-modules/terraform-google-project-factory#448. Could we get this released along with the main resource so that the email field is available from the start?