Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set context early on in LoadAndValidate to prevent NPE #3800

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

slevenick
Copy link
Contributor

I do not know that this will fix the problem, but I believe it will. Cannot reproduce crash locally even though context is verified to be nil going in to creds, err := googleoauth.CredentialsFromJSON(c.context, []byte(contents), clientScopes...)

Release Note Template for Downstream PRs (will be copied)

Fixed crash due to nil context when loading credentials

@google-cla google-cla bot added the cla: yes label Jul 30, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 2 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=136752"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccActiveDirectoryDomain_update|TestAccComputeRouterInterface_withTunnel|TestAccComputeRouterInterface_basic|TestAccEndpointsService_basic|TestAccHealthcareDicomStore_basic You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=136753"

@slevenick slevenick requested a review from c2thorn July 30, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants