Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend service support for internet NEG backend #3782

Merged
merged 7 commits into from
Jul 25, 2020

Conversation

slevenick
Copy link
Contributor

@slevenick slevenick commented Jul 24, 2020

Fixes: hashicorp/terraform-provider-google#6155

Similar to #3764 but with virtual field to strip max_utilization from request body. This allows users of the regular backend service to send max_utilization = 0.0, but will show max_utilization in initial create diff of a backend with a network endpoint

Add ability to set global network endpoint group as backend for backend service. Make health_checks optional if NEG is used. Virtual field added to enable this

Release Note Template for Downstream PRs (will be copied)

compute: Added support to `google_compute_backend_service` for setting a network endpoint group as `backend.group`

@google-cla google-cla bot added the cla: yes label Jul 24, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 137 insertions(+), 24 deletions(-))
Terraform Beta: Diff ( 3 files changed, 137 insertions(+), 24 deletions(-))
Ansible: Diff ( 1 file changed, 3 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 1 file changed, 15 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135457"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_internalLoadBalancing|TestAccComputeInstanceGroup_rename|TestAccContainerCluster_backend|TestAccFolderIamAuditConfig_multiple You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135459"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 145 insertions(+), 22 deletions(-))
Terraform Beta: Diff ( 3 files changed, 145 insertions(+), 22 deletions(-))
Ansible: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 23 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135461"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccComputeBackendService_internalLoadBalancing|TestAccComputeInstanceGroup_rename|TestAccContainerCluster_backend You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135462"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 128 insertions(+), 22 deletions(-))
Terraform Beta: Diff ( 3 files changed, 128 insertions(+), 22 deletions(-))
Ansible: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 19 insertions(+))
TF OiCS: Diff ( 4 files changed, 125 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135467"

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 128 insertions(+), 22 deletions(-))
Terraform Beta: Diff ( 3 files changed, 128 insertions(+), 22 deletions(-))
Ansible: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 19 insertions(+))
TF OiCS: Diff ( 4 files changed, 125 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135468"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_backendServiceNetworkEndpointExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135469"

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccFolderIamAuditConfig_multiple You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135470"

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a quick docs change. Can you also update the title of this PR to reflect the new approach, and update the changelog to not have backticks around compute?

products/compute/api.yaml Show resolved Hide resolved
@slevenick slevenick changed the title Backend neg virtual field implementation Backend service support for internet NEG backend Jul 25, 2020
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 131 insertions(+), 22 deletions(-))
Terraform Beta: Diff ( 3 files changed, 131 insertions(+), 22 deletions(-))
Ansible: Diff ( 2 files changed, 11 insertions(+), 8 deletions(-))
TF Conversion: Diff ( 1 file changed, 19 insertions(+))
TF OiCS: Diff ( 4 files changed, 125 insertions(+))
Inspec: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135547"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend service resource cannot be used with global network endpoint
3 participants