-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend service support for internet NEG backend #3782
Backend service support for internet NEG backend #3782
Conversation
…nd service. Make health_checks optional
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 137 insertions(+), 24 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135457" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_internalLoadBalancing|TestAccComputeInstanceGroup_rename|TestAccContainerCluster_backend|TestAccFolderIamAuditConfig_multiple You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135459" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 145 insertions(+), 22 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135461" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccComputeBackendService_internalLoadBalancing|TestAccComputeInstanceGroup_rename|TestAccContainerCluster_backend You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135462" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 128 insertions(+), 22 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135467" |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 128 insertions(+), 22 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135468" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_backendServiceNetworkEndpointExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135469" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeBackendService_backendServiceNetworkEndpointExample|TestAccFolderIamAuditConfig_multiple You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135470" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a quick docs change. Can you also update the title of this PR to reflect the new approach, and update the changelog to not have backticks around compute?
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 131 insertions(+), 22 deletions(-)) |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=135547" |
Fixes: hashicorp/terraform-provider-google#6155
Similar to #3764 but with virtual field to strip
max_utilization
from request body. This allows users of the regular backend service to sendmax_utilization = 0.0
, but will showmax_utilization
in initial create diff of a backend with a network endpointAdd ability to set global network endpoint group as backend for backend service. Make health_checks optional if NEG is used. Virtual field added to enable this
Release Note Template for Downstream PRs (will be copied)