Add sibling import to cloudidentity #3769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm the modular magician. Your PR hasn't generated any diffs, but I'll let you know if a future commit does. |
|
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134829" |
|
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock|TestAccServiceAccountIamBinding_withAndWithoutCondition|TestAccServiceAccountIamMember_withAndWithoutCondition|TestAccMonitoringMetricDescriptor_monitoringMetricDescriptorAlertExample You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=134833" |
megan07
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ended up fixing my import problems (for now).
goimportsgets confused about sibling imports sometimes, particularly when using a non-v1 package. It will generally add the explicit package name in these cases. However, for whatever reason, that wasn't working and it was removing it entirely instead. If the imports already starts with the sibling import specified, it's sticky (since that's how you would rename the package it gets preserved) and tends to work. Computers 🤷♀️Release Note Template for Downstream PRs (will be copied)