Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD Domain resource added #3735

Conversation

venkykuberan
Copy link
Contributor

@venkykuberan venkykuberan commented Jul 9, 2020

Release Note Template for Downstream PRs (will be copied)

`google_active_directory_domain`

reference: hashicorp/terraform-provider-google#5731

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@emilymye, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 947 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 947 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 104 insertions(+))
TF OiCS: Diff ( 4 files changed, 106 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 947 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 947 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 104 insertions(+))
TF OiCS: Diff ( 4 files changed, 106 insertions(+))

@venkykuberan venkykuberan requested review from danawillow and removed request for emilymye July 9, 2020 18:13
products/activedirectory/api.yaml Outdated Show resolved Hide resolved
products/activedirectory/api.yaml Show resolved Hide resolved
products/activedirectory/api.yaml Outdated Show resolved Hide resolved
products/activedirectory/api.yaml Show resolved Hide resolved
products/activedirectory/api.yaml Show resolved Hide resolved
products/activedirectory/api.yaml Outdated Show resolved Hide resolved
products/activedirectory/terraform.yaml Outdated Show resolved Hide resolved
products/activedirectory/api.yaml Show resolved Hide resolved
products/activedirectory/terraform.yaml Show resolved Hide resolved
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 935 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 935 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 109 insertions(+))
TF OiCS: Diff ( 4 files changed, 106 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 9 files changed, 936 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 9 files changed, 936 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 109 insertions(+))
TF OiCS: Diff ( 4 files changed, 106 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 951 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 10 files changed, 951 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 124 insertions(+))
TF OiCS: Diff ( 4 files changed, 106 insertions(+))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 10 files changed, 951 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 10 files changed, 951 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 3 files changed, 124 insertions(+))
TF OiCS: Diff ( 4 files changed, 106 insertions(+))

required: true
item_type: Api::Type::String
description: |
Locations where domain needs to be provisioned. [regions][compute/docs/regions-zones/]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants