Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom access level to access context manager #3653

Conversation

venkykuberan
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

access_context_manager: custom access level added to `google_access_context_manager_access_level`

fixes : hashicorp/terraform-provider-google#6527

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 261 insertions(+))
Terraform Beta: Diff ( 4 files changed, 261 insertions(+))
TF Conversion: Diff ( 1 file changed, 81 insertions(+))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=120834"

@venkykuberan venkykuberan requested review from danawillow and rileykarson and removed request for rileykarson and danawillow June 16, 2020 20:27
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the tests pass!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

access context manager access level custom levels
4 participants