Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty reservations must ignore empty #3541

Merged
merged 1 commit into from
May 20, 2020
Merged

Empty reservations must ignore empty #3541

merged 1 commit into from
May 20, 2020

Conversation

slevenick
Copy link
Contributor

Fixes bigquery reservation tests. Removed update test as there is now nothing to update without a real reservation

Release Note Template for Downstream PRs (will be copied)

@slevenick slevenick requested a review from danawillow May 20, 2020 16:50
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 3 files changed, 3 insertions(+), 24 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@slevenick slevenick requested review from emilymye and removed request for danawillow May 20, 2020 17:16
@slevenick slevenick merged commit 9c4f020 into GoogleCloudPlatform:master May 20, 2020
@modular-magician modular-magician mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilymye emilymye emilymye approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slevenick @modular-magician @emilymye @googlebot