Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cause node pool to be written to statefile even if creation fails. #3476

Conversation

nat-henderson
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#6287.

Release Note Template for Downstream PRs (will be copied)

container: Fix occasional error with `container_node_pool` partially-successful creations not being recorded if an error occurs on the GCP side.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 5 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 1 file changed, 5 insertions(+), 2 deletions(-))

@nat-henderson
Copy link
Contributor Author

Running the tests, will take a while.

@nat-henderson
Copy link
Contributor Author

Tests pass!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statefile Not updating for [GCE_STOCKOUT] errors
4 participants