Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node pool tests. #3475

Merged

Conversation

nat-henderson
Copy link
Contributor

@nat-henderson nat-henderson commented May 5, 2020

The core problem here is that the available node versions are such that
version (max - 1) is not compatible with the latest master version.

Fixes hashicorp/terraform-provider-google#6283.

Release Note Template for Downstream PRs (will be copied)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 40 deletions(-))
Terraform Beta: Diff ( 1 file changed, 40 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 88 deletions(-))
Terraform Beta: Diff ( 1 file changed, 88 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+), 1 deletion(-))

@danawillow
Copy link
Contributor

Anything preventing this from getting in?

@nat-henderson
Copy link
Contributor Author

Just the review! I'll assign you?

@nat-henderson nat-henderson requested review from danawillow and removed request for emilymye May 14, 2020 20:05
@nat-henderson nat-henderson merged commit 9adf7b8 into GoogleCloudPlatform:master May 14, 2020
@nat-henderson nat-henderson deleted the container-default-api branch May 14, 2020 20:12
nathkn pushed a commit to nathkn/magic-modules that referenced this pull request May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TestAccContainerNodePool* tests
4 participants