Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use atleastoneof for router interface fields #2852

Conversation

danawillow
Copy link
Contributor

I started looking at this for hashicorp/terraform-provider-google#4809, and saw that it was fixed yesterday in #2835. Since this solution reuses existing functionality, I thought it was worth adding even though the issue itself was fixed.

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 872f35b.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1542
depends: hashicorp/terraform-provider-google#5225

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yup, that's better. I'd assumed it was a case where AtLeastOneOf didn't work because it had a CustomizeDiff, but it had just had an old implementation it turns out.

danawillow and others added 2 commits December 19, 2019 21:10
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the is-4809-router-interface-atleastoneof branch from 872f35b to e145471 Compare December 19, 2019 21:11
@modular-magician modular-magician merged commit f374eb7 into GoogleCloudPlatform:master Dec 19, 2019
@danawillow danawillow deleted the is-4809-router-interface-atleastoneof branch December 19, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants