Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marked colab notebook execution tests that rely on dataform as min_version beta #13003

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

melinath
Copy link
Member

@melinath melinath commented Feb 7, 2025

Dataform resources are all beta-only.

Fixed hashicorp/terraform-provider-google#21250

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@melinath
Copy link
Member Author

melinath commented Feb 7, 2025

@modular-magician reassign-reviewer

Copy link

github-actions bot commented Feb 7, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from trodge February 7, 2025 19:12
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 10 insertions(+), 239 deletions(-))
google-beta provider: Diff ( 2 files changed, 22 insertions(+), 2 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 18
Passed tests: 18
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • colab

🟢 All tests passed!

View the build log

@melinath
Copy link
Member Author

melinath commented Feb 7, 2025

@trodge apologies for the noise but this should be ready for review now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccColabNotebookExecution_colabNotebookExecutionDataformExample
3 participants