Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google_chronicle_data_access_scope resource to chronicle #12647

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ankitgoyal0301
Copy link

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_chronicle_data_access_scope`

@github-actions github-actions bot requested a review from slevenick December 24, 2024 06:52
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 391 insertions(+))
google-beta provider: Diff ( 12 files changed, 1983 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 301 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_data_access_scope (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_data_access_scope" "primary" {
  name = # value needed
}

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 390 insertions(+))
google-beta provider: Diff ( 12 files changed, 1973 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 290 insertions(+))

Errors

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeBasicExample_update
  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithAssetNamespaceExample
  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithDataaccesslabelExample
  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithDeniedLabelsExample
  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithIngestionLabelExample
  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithLogtypeExample
    🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 391 insertions(+))
google-beta provider: Diff ( 12 files changed, 1983 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 301 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_data_access_scope (7 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_data_access_scope" "primary" {
  name = # value needed
}

@ankitgoyal0301
Copy link
Author

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 391 insertions(+)) google-beta provider: Diff ( 12 files changed, 1983 insertions(+), 2 deletions(-)) terraform-google-conversion: Diff ( 1 file changed, 301 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_chronicle_data_access_scope (7 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_chronicle_data_access_scope" "primary" {
  name = # value needed
}

Regarding the missing test report, the name is of the form projects/{{project}}/locations/{{location}}/instances/{{instance}}/dataAccessScopes/{{data_access_scope}}, which is derived from project, instance and location and data_access_scope passed seperately.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4387
Passed tests: 3948
Skipped tests: 429
Affected tests: 10

Click here to see the affected service packages

All service packages are affected

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeBasicExample_update
  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithAssetNamespaceExample
  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithDataaccesslabelExample
  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithDeniedLabelsExample
  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithIngestionLabelExample
  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithLogtypeExample
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccDataSourceGoogleQuotaInfo_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

1 similar comment
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4387
Passed tests: 3948
Skipped tests: 429
Affected tests: 10

Click here to see the affected service packages

All service packages are affected

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeBasicExample_update
  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithAssetNamespaceExample
  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithDataaccesslabelExample
  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithDeniedLabelsExample
  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithIngestionLabelExample
  • TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithLogtypeExample
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccDataSourceGoogleQuotaInfo_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithAssetNamespaceExample [Debug log]
TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithIngestionLabelExample [Debug log]
TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithLogtypeExample [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccChronicleDataAccessScope_chronicleDataaccessscopeBasicExample_update [Error message] [Debug log]
TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithDataaccesslabelExample [Error message] [Debug log]
TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithDeniedLabelsExample [Error message] [Debug log]
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@ankitgoyal0301
Copy link
Author

🟢 Tests passed during RECORDING mode: TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithAssetNamespaceExample [Debug log] TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithIngestionLabelExample [Debug log] TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithLogtypeExample [Debug log] TestAccDataSourceGoogleGkeHubFeature_basic [Debug log] TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode: TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode: TestAccChronicleDataAccessScope_chronicleDataaccessscopeBasicExample_update [Error message] [Debug log] TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithDataaccesslabelExample [Error message] [Debug log] TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithDeniedLabelsExample [Error message] [Debug log] TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log] TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

The below given tests are dependent on this PR to be submitted first:
TestAccChronicleDataAccessScope_chronicleDataaccessscopeBasicExample_update
TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithDataaccesslabelExample
TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithDeniedLabelsExample

Other failing tests are unrelated to our product.

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithAssetNamespaceExample [Debug log]
TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithIngestionLabelExample [Debug log]
TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithLogtypeExample [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccSecureSourceManagerInstance_secureSourceManagerInstancePrivatePscBackendExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccChronicleDataAccessScope_chronicleDataaccessscopeBasicExample_update [Error message] [Debug log]
TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithDataaccesslabelExample [Error message] [Debug log]
TestAccChronicleDataAccessScope_chronicleDataaccessscopeWithDeniedLabelsExample [Error message] [Debug log]
TestAccDataSourceGoogleQuotaInfo_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants