Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote Suspend/Resume to GA #12632

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chayankumar999
Copy link
Contributor

mmv1/third_party/terraform/website/docs/r/compute_region_instance_group_manager.html.markdown

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: Promoting 'standby_policy', 'target_suspended_size', 'target_stopped_size' fields of 'resource_compute_region_instance_group_manager' & 'resource_compute_nstance_group_manager' to ga.

mmv1/third_party/terraform/website/docs/r/compute_region_instance_group_manager.html.markdown
@github-actions github-actions bot requested a review from BBBmau December 20, 2024 17:22
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 439 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 4 files changed, 12 insertions(+), 10 deletions(-))

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@chayankumar999 chayankumar999 marked this pull request as draft December 20, 2024 17:33
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1077
Passed tests: 1004
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages
  • compute
#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccInstanceGroupManager_stoppedSuspendedTargetSize
  • TestAccRegionInstanceGroupManager_stoppedSuspendedTargetSize
    🟢 All tests passed!

View the build log

@chayankumar999
Copy link
Contributor Author

FYI: Currently this PR is blocked by version upgrade of golang/api. Once the PR is submitted we should be fine to continue with this PR.

@chayankumar999
Copy link
Contributor Author

FYI: Currently this PR is blocked by version upgrade of golang/api. Once the PR is submitted we should be fine to continue with this PR.

Or if it is ok to include those changes (about golang version upgrade) in the same PR, I can do it as well. Please let me know, if we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants