Fix error drop column with BigQuery flexible column names

[shoumoji]

Fix: hashicorp/terraform-provider-google#20750

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

bigquery: fixed DROP COLUMN error with bigquery flexible column names in `google_bigquery_table`

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[shoumoji]

If droppedColumns = []string("column1", "column2") ,

backquotedDroppedColumns = []string("`column1`", "`column2`")
droppedColumnsString = "`column1`, DROP COLUMN `column2`"
dropColumnsDDL = "ALTER TABLE <table_id> DROP Column `column1`, DROP COLUMN `column2`"

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 5 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 128
Passed tests: 114
Skipped tests: 10
Affected tests: 4

Click here to see the affected service packages

• bigquery

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigQueryTable_DropColumns
• TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTag
• TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTagNames
• TestAccBigQueryTable_Update_SchemaWithPolicyTagsToNoPolicyTag

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccBigQueryTable_DropColumns [Debug log]
TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTag [Debug log]
TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTagNames [Debug log]
TestAccBigQueryTable_Update_SchemaWithPolicyTagsToNoPolicyTag [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[wj-chen]

Thank you for the fix! Can you also update the test in

magic-modules/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table_test.go.tmpl

Line 114 in 1a28a91

func TestAccBigQueryTable_DropColumns(t *testing.T) {

to cover dropping a column with a reserved word in the name?

[github-actions]

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[shoumoji]

@wj-chen

The test results revealed that the cause of this error is not a reserved word, but rather the use of flexible column name with a dash character.

Therefore, I added tests and update of the issue and PR.
There are no changes to the code, as this issue can be resolved by backquoting the column names.

e.g.

• Success test case: the column name for
  • reserved word "for"
• Fail test case: the column name foo-bar, foo&bar and foo=bar
  • no reserved word, but with flexibile column name "-", "&" and "="

[github-actions]

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 17 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 19 insertions(+), 7 deletions(-))

[modular-magician]

Tests analytics

Total tests: 128
Passed tests: 117
Skipped tests: 10
Affected tests: 1

Click here to see the affected service packages

• bigquery

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigQueryTable_DropColumns

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccBigQueryTable_DropColumns [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

[wj-chen]

One comment about indentation otherwise looks good, thank you

[shoumoji]

One comment about indentation otherwise looks good, thank you

@wj-chen
Thank you for the review!!
I fixed it.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 17 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 19 insertions(+), 7 deletions(-))

[modular-magician]

Tests analytics

Total tests: 128
Passed tests: 118
Skipped tests: 10
Affected tests: 0

Click here to see the affected service packages

• bigquery

🟢 All tests passed!

View the build log

[shuyama1]

Thank you!