Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TeamCity testing project for ephemeral resources feature branch, clean up imports #11847

Conversation

SarahFrench
Copy link
Collaborator

@SarahFrench SarahFrench commented Sep 26, 2024

Adding projects in our TeamCity environment for testing ephemeral resources

This project will:

  • Use a more recent Terraform binary version that contains the ephemeral feature
    • See EphemeralResourcesTfCoreVersion
  • Have builds only for services were we're adding ephemeral resources
  • Have builds that allow using the hashicorp and modular-magician owned repos (can test PRs pre-merge)
  • CRON triggers to schedule builds (that use the hashicorp repo) every night

Preview of the changes

Here is a test project where this PR's config is deployed: https://hashicorp.teamcity.com/project/TerraformProviders_TerraformProviderGoogleSarahCheckingEphemeralTesting?mode=builds

This is what the new addition to TeamCity will look like - we only need to test the resourcemanager package as all ephemeral resources we want to add are in that package:

Screenshot 2024-10-03 at 21 15 35

Here's a look at the trigger set on the builds using the HashiCorp-owned repos:

Screenshot 2024-10-03 at 21 18 53

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 156 insertions(+))

@SarahFrench SarahFrench changed the title Add initial version of testing project for ephemeral resources Add TeamCity testing project for ephemeral resources feature branch, clean up imports Oct 3, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 192 insertions(+), 11 deletions(-))

@SarahFrench SarahFrench marked this pull request as ready for review October 3, 2024 20:22
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 194 insertions(+), 12 deletions(-))

Copy link
Collaborator

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good!

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 192 insertions(+), 11 deletions(-))

@SarahFrench SarahFrench merged commit 5fe624f into GoogleCloudPlatform:main Oct 7, 2024
11 checks passed
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 10, 2024
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 11, 2024
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants