-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add datasource for google_compute_region_instance_group_manager #11720
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Tests analyticsTotal tests: 4044 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. |
The error in tests is unrelated with the change |
.../terraform/services/compute/data_source_google_compute_region_instance_group_manager_test.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/d/compute_region_instance_group_manager.html.markdown
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/d/compute_region_instance_group_manager.html.markdown
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments. Approving
Tests analyticsTotal tests: 4065 Click here to see the affected service packages
View the build log |
Tests analyticsTotal tests: 4065 Click here to see the affected service packages
View the build log |
@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...party/terraform/services/compute/data_source_google_compute_region_instance_group_manager.go
Outdated
Show resolved
Hide resolved
...party/terraform/services/compute/data_source_google_compute_region_instance_group_manager.go
Outdated
Show resolved
Hide resolved
…_compute_region_instance_group_manager.go Co-authored-by: Thomas Rodgers <[email protected]>
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
Tests were added that are skipped in VCR:
View the build log |
...party/terraform/services/compute/data_source_google_compute_region_instance_group_manager.go
Outdated
Show resolved
Hide resolved
...party/terraform/services/compute/data_source_google_compute_region_instance_group_manager.go
Outdated
Show resolved
Hide resolved
...party/terraform/services/compute/data_source_google_compute_region_instance_group_manager.go
Outdated
Show resolved
Hide resolved
Tests analyticsTotal tests: 4088 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.
|
…_compute_region_instance_group_manager.go Co-authored-by: Thomas Rodgers <[email protected]>
…_compute_region_instance_group_manager.go Co-authored-by: Thomas Rodgers <[email protected]>
…_compute_region_instance_group_manager.go Co-authored-by: Thomas Rodgers <[email protected]>
2 similar comments
Tests analyticsTotal tests: 4088 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
2 similar comments
Tests analyticsTotal tests: 4088 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests analyticsTotal tests: 4088 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. |
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. |
Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made. Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer. |
|
…leCloudPlatform#11720) Co-authored-by: Thomas Rodgers <[email protected]>
…leCloudPlatform#11720) Co-authored-by: Thomas Rodgers <[email protected]>
This PR creates a datasource for google_compute_region_instance_group_manager.
It's based on existing (zonal) google_compute_instance_group_manager datasource and historical #7061
fixes #13363
Release Note Template for Downstream PRs (will be copied)