-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Resource v1 SCC Findings Export to BQ Folder Config #11587
Add Resource v1 SCC Findings Export to BQ Folder Config #11587
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
A Cloud Security Command Center (Cloud SCC) Big Query Export Config. | ||
It represents exporting Security Command Center data, including assets, findings, and security marks | ||
using gcloud scc bqexports | ||
~> **Note:** In order to use Cloud SCC resources, your organization must be enrolled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might need an additional newline here - for example, see https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/scc_folder_notification_config.
https://googlecloudplatform.github.io/magic-modules/develop/resource/#add-documentation has information on how to test documentation output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes - sorry for being unclear. Both resources are incorrect. The link was to a resource that looks wrong. A warning note is supposed to display like this:
Source: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/bigquery_dataset
An informational note should display like this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing clarity on this. Addressed.
..._party/terraform/services/securitycenter/resource_scc_folder_big_query_export_config_test.go
Outdated
Show resolved
Hide resolved
..._party/terraform/services/securitycenter/resource_scc_folder_big_query_export_config_test.go
Show resolved
Hide resolved
…older-level-config
…older-level-config
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
PreCheck: func() { acctest.AccTestPreCheck(t) }, | ||
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t), | ||
ExternalProviders: map[string]resource.ExternalProvider{ | ||
"random": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: random provider isn't used
"random": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed.
"github.com/hashicorp/terraform-provider-google/google/envvar" | ||
) | ||
|
||
func TestAccSecurityCenterFolderBigQueryExportConfig_basic(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func TestAccSecurityCenterFolderBigQueryExportConfig_basic(t *testing.T) { | |
func TestAccSecurityCenterFolderBigQueryExportConfig_update(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed.
..._party/terraform/services/securitycenter/resource_scc_folder_big_query_export_config_test.go
Show resolved
Hide resolved
..._party/terraform/services/securitycenter/resource_scc_folder_big_query_export_config_test.go
Show resolved
Hide resolved
..._party/terraform/services/securitycenter/resource_scc_folder_big_query_export_config_test.go
Show resolved
Hide resolved
Also clarified the change request on #11587 (comment) |
mmv1/templates/terraform/examples/scc_folder_big_query_export_config_basic.tf.erb
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 17 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 17 Click here to see the affected service packages
View the build log |
dataset_id := "tf_test_" + randomSuffix | ||
dataset_id2 := "tf_test_" + randomSuffix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle this works, but right now the values here are both the same, so it won't actually trigger a change to the dataset resource.
dataset_id := "tf_test_" + randomSuffix | |
dataset_id2 := "tf_test_" + randomSuffix | |
dataset_id := "tf_test_" + randomSuffix | |
dataset_id2 := "tf_test_" + acctest.RandString(t, 10) |
Or alternatively:
dataset_id := "tf_test_" + randomSuffix | |
dataset_id2 := "tf_test_" + randomSuffix | |
dataset_id := "tf_test_" + randomSuffix | |
dataset_id2 := dataset_id + "2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
…older-level-config
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 17 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Related to http://b/356159589.
Bug Description: hashicorp/terraform-provider-google#18848
Adding new template for V1 SCC Findings Exports to Big Query Folder Config
https://cloud.google.com/security-command-center/docs/reference/rest/v1/folders.bigQueryExports
Release Note Template for Downstream PRs (will be copied)