Add Resource v1 SCC Findings Export to BQ Folder Config #11587

vijaykanthm · 2024-08-29T22:55:18Z

Bug Description: hashicorp/terraform-provider-google#18848

Adding new template for V1 SCC Findings Exports to Big Query Folder Config
https://cloud.google.com/security-command-center/docs/reference/rest/v1/folders.bigQueryExports

Release Note Template for Downstream PRs (will be copied)

`google_scc_folder_scc_big_query_export`

github-actions · 2024-08-29T22:55:54Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

mmv1/products/securitycenter/FolderSccBigQueryExports.yaml

melinath · 2024-09-05T18:08:53Z

mmv1/products/securitycenter/FolderSccBigQueryExports.yaml

+  A Cloud Security Command Center (Cloud SCC) Big Query Export Config.
+  It represents exporting Security Command Center data, including assets, findings, and security marks
+  using gcloud scc bqexports
+  ~> **Note:** In order to use Cloud SCC resources, your organization must be enrolled


I think you might need an additional newline here - for example, see https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/scc_folder_notification_config.

https://googlecloudplatform.github.io/magic-modules/develop/resource/#add-documentation has information on how to test documentation output.

I didn't understand what you are trying to say here, the example link which you have provided for notification Config doesn't have a newline. I have used the document preview tool for the existing description in my code and it is the same as that of the notification config description.

yes - sorry for being unclear. Both resources are incorrect. The link was to a resource that looks wrong. A warning note is supposed to display like this:

Source: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/bigquery_dataset

An informational note should display like this:

Source: https://registry.terraform.io/providers/hashicorp/google/latest/docs/data-sources/compute_instance_template

Thanks for providing clarity on this. Addressed.

mmv1/products/securitycenter/FolderSccBigQueryExports.yaml

..._party/terraform/services/securitycenter/resource_scc_folder_big_query_export_config_test.go

mmv1/products/securitycenter/FolderSccBigQueryExports.yaml

…older-level-config

…ssions #11587

melinath · 2024-09-11T22:09:07Z

..._party/terraform/services/securitycenter/resource_scc_folder_big_query_export_config_test.go

+		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
+		ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
+		ExternalProviders: map[string]resource.ExternalProvider{
+			"random": {},


nit: random provider isn't used

Suggested change

"random": {},

melinath · 2024-09-11T22:10:24Z

..._party/terraform/services/securitycenter/resource_scc_folder_big_query_export_config_test.go

+	"github.com/hashicorp/terraform-provider-google/google/envvar"
+)
+
+func TestAccSecurityCenterFolderBigQueryExportConfig_basic(t *testing.T) {


Suggested change

func TestAccSecurityCenterFolderBigQueryExportConfig_basic(t *testing.T) {

func TestAccSecurityCenterFolderBigQueryExportConfig_update(t *testing.T) {

..._party/terraform/services/securitycenter/resource_scc_folder_big_query_export_config_test.go

melinath · 2024-09-11T22:17:42Z

Also clarified the change request on #11587 (comment)

mmv1/templates/terraform/examples/scc_folder_big_query_export_config_basic.tf.erb

modular-magician · 2024-09-12T22:02:47Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 926 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 926 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician · 2024-09-12T22:08:42Z

Tests analytics

Total tests: 17
Passed tests: 16
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

securitycenter

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSecurityCenterFolderBigQueryExportConfig_update

Get to know how VCR tests work

modular-magician · 2024-09-12T22:15:39Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecurityCenterFolderBigQueryExportConfig_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

modular-magician · 2024-09-12T22:36:42Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 926 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 926 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician · 2024-09-12T22:43:07Z

Tests analytics

Total tests: 17
Passed tests: 17
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

securitycenter

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

melinath · 2024-09-13T20:54:25Z

..._party/terraform/services/securitycenter/resource_scc_folder_big_query_export_config_test.go

+	dataset_id := "tf_test_" + randomSuffix
+	dataset_id2 := "tf_test_" + randomSuffix


In principle this works, but right now the values here are both the same, so it won't actually trigger a change to the dataset resource.

Suggested change

dataset_id := "tf_test_" + randomSuffix

dataset_id2 := "tf_test_" + randomSuffix

dataset_id := "tf_test_" + randomSuffix

dataset_id2 := "tf_test_" + acctest.RandString(t, 10)

Or alternatively:

Suggested change

dataset_id := "tf_test_" + randomSuffix

dataset_id2 := "tf_test_" + randomSuffix

dataset_id := "tf_test_" + randomSuffix

dataset_id2 := dataset_id + "2"

…older-level-config

modular-magician · 2024-09-13T21:53:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 926 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 926 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 89 insertions(+))

modular-magician · 2024-09-13T21:59:15Z

Tests analytics

Total tests: 17
Passed tests: 16
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

securitycenter

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSecurityCenterFolderBigQueryExportConfig_update

Get to know how VCR tests work

modular-magician · 2024-09-13T22:06:16Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecurityCenterFolderBigQueryExportConfig_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

…latform#11587)

Add Resource v1 SCC Findings Export to BQ Folder Config

472d0dd

github-actions bot requested a review from melinath August 29, 2024 22:55

modular-magician added the service/securitycenter label Aug 29, 2024

This comment was marked as outdated.

Sign in to view

melinath requested changes Sep 5, 2024

View reviewed changes

melinath reviewed Sep 5, 2024

View reviewed changes

mmv1/products/securitycenter/FolderSccBigQueryExports.yaml Outdated Show resolved Hide resolved

melinath requested changes Sep 6, 2024

View reviewed changes

mmv1/products/securitycenter/FolderSccBigQueryExports.yaml Outdated Show resolved Hide resolved

Merge branch 'GoogleCloudPlatform:main' into scc-bigquery-export-v1-f…

e31c602

…older-level-config

github-actions bot requested a review from melinath September 6, 2024 19:29

This comment was marked as outdated.

Sign in to view

Merge branch 'GoogleCloudPlatform:main' into scc-bigquery-export-v1-f…

e442706

…older-level-config

github-actions bot requested a review from melinath September 9, 2024 19:34

This comment was marked as outdated.

Sign in to view

Address Comments

69dc655

This comment was marked as outdated.

Sign in to view

lint fix

d35d7c3

This comment was marked as outdated.

Sign in to view

melinath added a commit that referenced this pull request Sep 11, 2024

Added roles/securitycenter.bigQueryExportsEditor to test runner permi…

9119f51

…ssions #11587

melinath mentioned this pull request Sep 11, 2024

Added roles/securitycenter.bigQueryExportsEditor to test runner permissions #11687

Merged

melinath requested changes Sep 11, 2024

View reviewed changes

mmv1/templates/terraform/examples/scc_folder_big_query_export_config_basic.tf.erb Show resolved Hide resolved

This was referenced Sep 12, 2024

Added roles/securitycenter.bigQueryExportsEditor to test runner permissions hashicorp/terraform-provider-google-beta#8162

Merged

Added roles/securitycenter.bigQueryExportsEditor to test runner permissions hashicorp/terraform-provider-google#19452

Merged

Address comments

dcebeb6

github-actions bot requested a review from melinath September 12, 2024 21:50

fix failing lint check

564107d

melinath requested changes Sep 13, 2024

View reviewed changes

Merge branch 'GoogleCloudPlatform:main' into scc-bigquery-export-v1-f…

56f3311

…older-level-config

github-actions bot requested a review from melinath September 13, 2024 21:26

This comment was marked as outdated.

Sign in to view

Update the dataset id for new resource

7e2f6da

This comment was marked as outdated.

Sign in to view

melinath approved these changes Sep 13, 2024

View reviewed changes

melinath merged commit 6d67e34 into GoogleCloudPlatform:main Sep 13, 2024
13 checks passed

iyabchen pushed a commit to iyabchen/magic-modules that referenced this pull request Sep 14, 2024

Add Resource v1 SCC Findings Export to BQ Folder Config (GoogleCloudP…

7b83f02

…latform#11587)

abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 23, 2024

Add Resource v1 SCC Findings Export to BQ Folder Config (GoogleCloudP…

96c9122

…latform#11587)

niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024

Add Resource v1 SCC Findings Export to BQ Folder Config (GoogleCloudP…

c6c34d5

…latform#11587)

	func TestAccSecurityCenterFolderBigQueryExportConfig_basic(t *testing.T) {
	func TestAccSecurityCenterFolderBigQueryExportConfig_update(t *testing.T) {

		dataset_id := "tf_test_" + randomSuffix
		dataset_id2 := "tf_test_" + randomSuffix

Add Resource v1 SCC Findings Export to BQ Folder Config #11587

Add Resource v1 SCC Findings Export to BQ Folder Config #11587

Conversation

vijaykanthm commented Aug 29, 2024 • edited by melinath Loading

github-actions bot commented Aug 29, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melinath Sep 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melinath commented Sep 11, 2024

modular-magician commented Sep 12, 2024

Diff report

modular-magician commented Sep 12, 2024

Tests analytics

Action taken

modular-magician commented Sep 12, 2024

modular-magician commented Sep 12, 2024

Diff report

modular-magician commented Sep 12, 2024

Tests analytics

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as outdated.

This comment was marked as outdated.

modular-magician commented Sep 13, 2024

Diff report

modular-magician commented Sep 13, 2024

Tests analytics

Action taken

modular-magician commented Sep 13, 2024

vijaykanthm commented Aug 29, 2024 •

edited by melinath

Loading

melinath Sep 11, 2024 •

edited

Loading