Refactor muxing 2 : Remove unused code, resulting from #11903 #11578

SarahFrench · 2024-08-29T15:42:22Z

Follow up to #11903. Most commits in this PR are in that PR, and will 'disappear' once this PR is unblocked and ready for review.

This PR deletes all the parallel implementations of provider configuration logic. The PR #11903 stops the provider using this duplicated logic, and this PR removes that redundant code.

In future the team may want to revisit this deleted code to inform work to pulls out the SDKv2 from the codebase completely and the provider becomes 100% plugin-framework. As that is a long way in the future I think it's best to delete this code now for clarity. It will still be in version control for reference in the future.

Release Note Template for Downstream PRs (will be copied)

SarahFrench · 2024-09-26T11:07:19Z

Rebased to pull in Go rewrite

…atch

…ruct This allows the PF provider to access any data on the SDK provider, including the meta/Config struct that will be created when the SDK provider is configured.

…struct to all data sources and resources, instead of `FrameworkProviderConfig`

… Config struct to be usable in those places. - Replace use of FrameworkProviderConfig with Config - Add Beta-only `NewFirebaseClient` method to Config struct for use with Firebase data sources - Update LocationDescriber interface - Misc places where the SDK and PF type systems meet and string needs to be converted to types.StringType

…, adapt to type system changes

…rovider

- This carries over the idea of configuring the PF provider using the SDK provider. The changes in the MuxedProviders func mimic changes already made in main.go. - Remove unnecessary duplication of cached configs per test name; now one used regardless of PF/SDK - Updates to some DestroyProducer functions so they access the cached SDK Config struct to get a client - Remove GetFwTestProvider and the file containing it - this isn't needed.

…ovider-google#14158 - Use of older TPG versions through ExternalProviders breaks VCR, so that is also removed from TestAccDataSourceGoogleFirebaseAppleAppConfig

…" in the PF provider's meta struct

…e now ignored and ENVs can be used instead

…el_addition_strategy` acctest to reflect how the SDK configuration logic now affects the PF provider

…se of ExternalProviders to get other versions of TPG/TPGB

…Email instead.

…ific provider configuration code.

modular-magician · 2024-10-04T12:00:17Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 25 files changed, 171 insertions(+), 3891 deletions(-))
google-beta provider: Diff ( 31 files changed, 215 insertions(+), 4129 deletions(-))

modular-magician · 2024-10-04T13:09:51Z

Tests analytics

Total tests: 4139
Passed tests: 3721
Skipped tests: 411
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample

TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

TestAccDataformRepository_updated

TestAccDataprocCluster_withAutoscalingPolicy

TestAccFrameworkProviderBasePath_setBasePath

TestAccFrameworkProviderMeta_setModuleName

Get to know how VCR tests work

modular-magician · 2024-10-04T13:46:26Z

🟢 Tests passed during RECORDING mode:
TestAccFrameworkProviderBasePath_setBasePath[Debug log]
TestAccFrameworkProviderMeta_setModuleName[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log]
TestAccDataformRepository_updated[Error message] [Debug log]
TestAccDataprocCluster_withAutoscalingPolicy[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician added the service/firebase label Aug 29, 2024