Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export data.google_compute_default_service_account.name #1124

Merged
merged 2 commits into from
Jan 3, 2019
Merged

Export data.google_compute_default_service_account.name #1124

merged 2 commits into from
Jan 3, 2019

Conversation

sergei-ivanov
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#2611


[all]

[terraform]

The following additional attributes are exported from data.google_compute_default_service_account:

  • name
  • display_name
  • unique_id

Some code has been taken from data_source_google_service_account,
so that both data sources behave similarly.

Documentation has been updated with additional use cases.

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

modular-magician commented Jan 3, 2019

I am a robot that works on MagicModules PRs!

depends: hashicorp/terraform-provider-google#2778
depends: hashicorp/terraform-provider-google-beta#298

Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for adding this!

sergei-ivanov and others added 2 commits January 3, 2019 21:03
Fixes hashicorp/terraform-provider-google#2611

The following additional attributes are exported:
* `name`
* `display_name`
* `unique_id`

Some code has been taken from data_source_google_service_account,
so that both data sources behave similarly.

Documentation has been updated with additional use cases.
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 4e6b56a into GoogleCloudPlatform:master Jan 3, 2019
@sergei-ivanov sergei-ivanov deleted the google_compute_default_service_account.name branch January 3, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants