-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting both enable_autopilot and workload_identity_config in google_container_cluster resource #10691
Conversation
…oogle_container_cluster resource.
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerCluster_withWorkloadALTSConfigAutopilot|TestAccContainerCluster_withWorkloadIdentityConfigAutopilot |
|
…oogle_container_cluster resource.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only a small nitpick
mmv1/third_party/terraform/services/container/resource_container_cluster_test.go.erb
Outdated
Show resolved
Hide resolved
…oogle_container_cluster resource.
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
1 similar comment
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
Tests analyticsTotal tests: Click here to see the affected service packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…oogle_container_cluster resource (GoogleCloudPlatform#10691)
…oogle_container_cluster resource (GoogleCloudPlatform#10691)
…oogle_container_cluster resource (GoogleCloudPlatform#10691)
…oogle_container_cluster resource (GoogleCloudPlatform#10691)
…oogle_container_cluster resource (GoogleCloudPlatform#10691)
This PR enables the creation of GKE clusters with both Autopilot and WorkloadALTS enabled (both
enable_autopilot
andworkload_alts_config
block set).The
workloadALTSConfig
JSON field in the GKE cluster REST resource requires theworkloadIdentityConfig
field to be present as well, so theworkload_alts_config
block requires theworkload_identity_config
block to be present. This PR removes theConflictsWith
constraint betweenenable_autopilot
andworkload_identity_config
so that a non-emptyworkload_identity_config
block can be specified to satisfy the REST API to create the cluster.Release Note Template for Downstream PRs (will be copied)