Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Terraform] send scheduling block with automaticrestart if there is none in cfg #1033

Merged
merged 2 commits into from
Dec 12, 2018

Conversation

danawillow
Copy link
Contributor

The true default for automatic_restart only actually applies if a scheduling block was set. If there was not one set (i.e. the length of the array of nested objects is zero), then we should set it to a default explicitly. Fixes hashicorp/terraform-provider-google#1947.


[all]

[terraform]

send scheduling block with automaticrestart if there is none in cfg

[terraform-beta]

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#210
depends: hashicorp/terraform-provider-google#2638

@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!
I checked the downstream repositories (see README.md for which ones I can write to), and none of them seem to have any changes.

Once this PR is approved, you can feel free to merge it without taking any further steps.

@danawillow
Copy link
Contributor Author

Paddy, does this seem reasonable to you? I know you mentioned in the linked issue that you wanted to wait until 0.12, but I think we can solve it now. Also don't worry about the unrelated files in the TPG downstream, we'll get that sorted out shortly.

Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love it, but I love waiting for a solution less. Looks good to me. 👍

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 58533ab) have been included in your existing downstream PRs.

danawillow and others added 2 commits December 12, 2018 17:35
@modular-magician modular-magician merged commit 990d073 into GoogleCloudPlatform:master Dec 12, 2018
@danawillow danawillow deleted the tf-1947 branch December 12, 2018 17:39
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 221d28d) have been included in your existing downstream PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants