-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Terraform] send scheduling block with automaticrestart if there is none in cfg #1033
[Terraform] send scheduling block with automaticrestart if there is none in cfg #1033
Conversation
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
I am a robot that works on MagicModules PRs! Once this PR is approved, you can feel free to merge it without taking any further steps. |
Paddy, does this seem reasonable to you? I know you mentioned in the linked issue that you wanted to wait until 0.12, but I think we can solve it now. Also don't worry about the unrelated files in the TPG downstream, we'll get that sorted out shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love it, but I love waiting for a solution less. Looks good to me. 👍
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 58533ab) have been included in your existing downstream PRs. |
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
9f8ea34
to
aef0e3a
Compare
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit 221d28d) have been included in your existing downstream PRs. |
The true default for automatic_restart only actually applies if a scheduling block was set. If there was not one set (i.e. the length of the array of nested objects is zero), then we should set it to a default explicitly. Fixes hashicorp/terraform-provider-google#1947.
[all]
[terraform]
send scheduling block with automaticrestart if there is none in cfg
[terraform-beta]
[ansible]
[inspec]