Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cloud Run v2 resources creation failure state inconsistency #10298

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

yanweiguo
Copy link
Member

Fixes github.com/hashicorp/terraform-provider-google/issues/17245.

This follows the solution of Cloud Function V2 generation to fix a similar issue: #8545

Release Note Template for Downstream PRs (will be copied)

cloudrunv2: fixed Terraform state inconsistency when resource `google_cloud_run_v2_job` creation fails
cloudrunv2: fixed Terraform state inconsistency when resource `google_cloud_run_v2_service` creation fails

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from c2thorn March 26, 2024 22:06
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 6 deletions(-))
google-beta provider: Diff ( 2 files changed, 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 39
Passed tests: 38
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • cloudrunv2

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccCloudRunV2Service_cloudrunv2ServiceGRPCProbesUpdate

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudRunV2Service_cloudrunv2ServiceGRPCProbesUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@c2thorn
Copy link
Member

c2thorn commented Mar 27, 2024

/gcbrun

@c2thorn
Copy link
Member

c2thorn commented Mar 27, 2024

unit test builder ran out of memory, retrying for green checks

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 6 deletions(-))
google-beta provider: Diff ( 2 files changed, 6 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 39
Passed tests: 39
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • cloudrunv2

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@c2thorn c2thorn merged commit 28bed1d into GoogleCloudPlatform:main Mar 27, 2024
14 checks passed
@c2thorn
Copy link
Member

c2thorn commented Mar 27, 2024

Forgot to re-approve, but LGTM

cmfeng pushed a commit to cmfeng/cmfeng-magic-modules that referenced this pull request Apr 5, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request Apr 19, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants