Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: Kueue cohort tutorial samples #498

Closed
wants to merge 17 commits into from
Closed

samples: Kueue cohort tutorial samples #498

wants to merge 17 commits into from

Conversation

rbarberop
Copy link
Collaborator

This PR contains the yaml examples for the new Kueue tutorial using cohorts for resource sharing.

It contains v1beta1 code, so this PR should be blocked by kubernetes-sigs/kueue#532

Original v1alpha2 code is still on each file for reference. That part should be deleted on each file before merging.

@rbarberop rbarberop requested a review from a team as a code owner February 17, 2023 14:56
@google-cla
Copy link

google-cla bot commented Feb 17, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@snippet-bot
Copy link

snippet-bot bot commented Feb 17, 2023

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@rbarberop
Copy link
Collaborator Author

FYI @alculquicondor

batch/kueue-cohort/create_jobs.sh Outdated Show resolved Hide resolved
batch/kueue-cohort/flavors.yaml Outdated Show resolved Hide resolved
batch/kueue-cohort/spot-cq.yaml Outdated Show resolved Hide resolved
batch/kueue-cohort/flavors.yaml Outdated Show resolved Hide resolved
batch/kueue-cohort/spot-cq.yaml Outdated Show resolved Hide resolved
batch/kueue-cohort/team-a-cq.yaml Show resolved Hide resolved
batch/kueue-cohort/team-a-cq.yaml Outdated Show resolved Hide resolved
batch/kueue-cohort/team-a-cq.yaml Outdated Show resolved Hide resolved
batch/kueue-cohort/team-a-job.yaml Outdated Show resolved Hide resolved
batch/kueue-cohort/team-b-cq.yaml Show resolved Hide resolved
Copy link

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending removal of old yamls.

batch/kueue-cohort/flavors.yaml Outdated Show resolved Hide resolved
batch/kueue-cohort/team-a-cq.yaml Outdated Show resolved Hide resolved
batch/kueue-cohort/team-b-job.yaml Show resolved Hide resolved
@rbarberop rbarberop closed this by deleting the head repository Mar 17, 2023
@rbarberop rbarberop reopened this Mar 17, 2023
@rbarberop rbarberop mentioned this pull request Mar 27, 2023
@Shabirmean
Copy link
Member

@rbarberop can you update this branch with the latest changes from the base branch?

@Shabirmean Shabirmean changed the title Kueue cohort tutorial samples samples: Kueue cohort tutorial samples Mar 27, 2023
@Shabirmean
Copy link
Member

We shall bypass CLA check for @charlieyu1996 since he was a Googler when the commits were made!

@rbarberop rbarberop enabled auto-merge (squash) March 28, 2023 14:45



# ORIGINAL BELOW - KEPT FOR DOUBLE-CHECKING SYNTAX - TO BE DELETED BEFORE MERGE

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove old yamls

@rbarberop
Copy link
Collaborator Author

Unable to merge due to local repo issues. Will open a new PR.

@rbarberop rbarberop closed this Mar 28, 2023
auto-merge was automatically disabled March 28, 2023 17:38

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants