Adapt names to reviewed Kueue documentation #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @alculquicondor |
bourgeoisor
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
LGTM but before we merged we should have a CL ready to update https://cloud.google.com/kubernetes-engine/docs/tutorials/kueue-intro (for example I see some references of cq in there)
|
/hold |
|
Oops, nvm. I thought this was about the new API fields. This can merge. |
|
CL created @bourgeoisor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kueue documentation has been updated recently.
This PR uses the same ResourceFlavor names than in documentation.
It also gives different names to jobs generated for both teams, so the output of the commands in the tutorial are more descriptive.